New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] createPlayerAccount 操作没有使用 try{} catch{} 代码块包裹，返回值未进行检查 #5

Open

Ghost-chu opened this issue Feb 21, 2022 · 0 comments

Ghost-chu commented Feb 21, 2022

createPlayerAccount 并非每个插件都支持，应使用 try{} catch{} 代码块进行包裹进行错误处理。

Ecore/src/main/java/cat/nyaa/ecore/EconomyCoreProvider.java

Line 66 in 6cf99c5

economy.createPlayerAccount(vaultPlayer);

该处的 createPlayerAccount 方法的返回值未检查，直接按照假定成功进行了控制台输出，在debug时可能导致不必要的麻烦。

Lori3f6 mentioned this issue

[BUG] 没有对 Economy 操作结果进行处理，返回值被忽略 #4

Open

Lori3f6 added a commit that referenced this issue


          fix: issue #4 #5

4be26e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment