Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub workflow runs are sorted by update date #4

Open
haykam821 opened this issue Jun 12, 2023 · 0 comments
Open

GitHub workflow runs are sorted by update date #4

haykam821 opened this issue Jun 12, 2023 · 0 comments

Comments

@haykam821
Copy link

If two workflow runs targeting different commits are triggered in quick succession, and the workflow run based on the old commit finishes last, then the artifact chosen will be based on the old commit.

The sorting logic should be improved to handle this case:

let mut workflow_runs = client.get_workflow_runs(owner, repository).await?.workflow_runs;
workflow_runs.sort_by_key(|run| cmp::Reverse(run.updated_at));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant