Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetProjectsReferencingProjectJson has wrong "ProjectJson" metadata for projectname.project.json #1863

Closed
jasonmalinowski opened this issue Dec 21, 2015 · 4 comments
Milestone

Comments

@jasonmalinowski
Copy link
Member

The code today:

<ItemGroup Condition="'$(ResolveNuGetPackages)' == 'true'">
  <_ProjectReferencingProjectJsonFile Include="$(MSBuildProjectFullPath)">
    <ProjectReferences>@(ProjectReference)</ProjectReferences>
    <ProjectJson>$(MSBuildProjectDirectory)\project.json</ProjectJson>
  </_ProjectReferencingProjectJsonFile>
</ItemGroup>

The ProjectJson is hard-coded to project.json, but it might have been [projectname].project.json in reality.

(Mentioned internally in bug 149651 and also by @onovotny.)

@jasonmalinowski
Copy link
Member Author

@yishaigalatzer, @emgarten: Is NuGet actually using this property? When @Pilchie and I saw this internally a month or so ago we weren't sure.

@jasonmalinowski jasonmalinowski self-assigned this Dec 21, 2015
@yishaigalatzer
Copy link

I don't believe we do, as we generate our own target file in nuget.exe. @onovotny Did you actually hit an issue?

@clairernovotny
Copy link

I did not hit any issues related to this. I just noticed it when trying to see what and how the TFM's were used in the targets file and thought it was suspicious.

@nkolev92
Copy link
Member

Moved to dotnet/NuGet.BuildTasks#79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants