-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] There is no colon “:” on the right of string “by” for non-recommended package in “Browse” tab of PM UI #13789
Comments
It could be that the localization was done differently by the loc team for the new "by" label I introduced for package owners (hyperlinks). The recommended packages are still using the original string. Just for clarity, in |
Recapping some offline discussions: There are 2 strings, one for Owner, one for Authors. The 6 languages (CHS, CHT, JAP, KOR, TRK, PLK) called out as missing a ":" are adding that colon for the "by {0}" but not for the "by" string. Goal: My suggestion is that we don't try to force a ":" or remove a ":" to gain consistency. Instead, let the culture decide whether it's added or not. If it's added to one string in a given culture, add it to both strings for that culture. |
NuGet Product Used
Visual Studio Package Management UI
Product Version
NuGet Client Dev\6.12.0.82
Worked before?
It is a regression issue since it doesn't repro on D16.11\34601.136.
Impact
It bothers me. A fix would be nice
Repro Steps & Context
Installation:
Repro Steps:
Expected:
The non-recommended package should have a semicolon “:” on the right of string “by” (just like the recommend packages).
Actual:
There is no semicolon “:” on the right of string “by” for non-recommended package.
Notes:
1.The repro rate is 100%.
2.It just reproes on the local languages: CHS, CHT, JPA, KOR, TRK, PLK.
3.There is a semicolon “:” for the string “by” in the tooltip of the same package as the screenshot below.
4. It just reproes in ”Browse” tab, doesn’t repro in ”Installed”/”Updates”/”Consolidate” tab.
Verbose Logs
No response
The text was updated successfully, but these errors were encountered: