Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] There is no colon “:” on the right of string “by” for non-recommended package in “Browse” tab of PM UI #13789

Open
SueSu01 opened this issue Sep 14, 2024 · 2 comments
Assignees
Labels
Found:ManualTests Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Client Type:Bug

Comments

@SueSu01
Copy link

SueSu01 commented Sep 14, 2024

NuGet Product Used

Visual Studio Package Management UI

Product Version

NuGet Client Dev\6.12.0.82

Worked before?

It is a regression issue since it doesn't repro on D16.11\34601.136.

Impact

It bothers me. A fix would be nice

Repro Steps & Context

Installation:

  1. Create a clean VM with loc OS (such as Windows-11-Enterprise-22H2-ZH-CN)
  2. Install VS D17.12\35312.88 from: Pipelines - Run rel.d17.12-35312.88 (visualstudio.com) with loc language pack (such as CHS)

Repro Steps:

  1. Create a C# Console App (.NET Core 9.0) in VS after setting a loc language CHS through menu “Tools->Options->Environment->International Settings->Language”.
  2. Right-click the project in Solution Explorer window and select "Manage NuGet Packages…" menu item to open PM UI.
  3. Go to ‘Browse’ tab.
  4. Observe the string “by” on the right of package name in the loaded package list.

Expected:    
The non-recommended package should have a semicolon “:” on the right of string “by” (just like the recommend packages).

Actual:
There is no semicolon “:” on the right of string “by” for non-recommended package.
image

Notes:   
1.The repro rate is 100%.
2.It just reproes on the local languages: CHS, CHT, JPA, KOR, TRK, PLK.
3.There is a semicolon “:” for the string “by” in the tooltip of the same package as the screenshot below.
image
4. It just reproes in ”Browse” tab, doesn’t repro in ”Installed”/”Updates”/”Consolidate” tab.

Verbose Logs

No response

@donnie-msft
Copy link
Contributor

It could be that the localization was done differently by the loc team for the new "by" label I introduced for package owners (hyperlinks). The recommended packages are still using the original string.

Just for clarity, in US-EN I don't expect a colon (:) in the string, but if it's typical for CHS, then yes the loc team should be contacted.

@nkolev92 nkolev92 changed the title [Localization] There is no semicolon “:” on the right of string “by” for non-recommended package in “Browse” tab of PM UI [Localization] There is no colon “:” on the right of string “by” for non-recommended package in “Browse” tab of PM UI Sep 30, 2024
@nkolev92 nkolev92 added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Sep 30, 2024
@donnie-msft
Copy link
Contributor

Recapping some offline discussions:

There are 2 strings, one for Owner, one for Authors.
Recommended packages are always Authors. That string is "by {0}"
"non-recommended" packages are sometimes Owners: That string is "by"

The 6 languages (CHS, CHT, JAP, KOR, TRK, PLK) called out as missing a ":" are adding that colon for the "by {0}" but not for the "by" string.
This might be a special case where we need to give hints to the localization team that the 2 strings are both describing lists.

Goal: My suggestion is that we don't try to force a ":" or remove a ":" to gain consistency. Instead, let the culture decide whether it's added or not. If it's added to one string in a given culture, add it to both strings for that culture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Found:ManualTests Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Client Type:Bug
Projects
None yet
Development

No branches or pull requests

4 participants