Pin React-dash to React v.15.6.2 #69

iris-i · 2017-10-08T20:42:17Z

Pin the package.json for React & React-Dom to 15.6.2, to avoid new builds getting setup with v16.
Story: #68

iris-i · 2017-10-10T13:44:48Z

Testing Steps:

Running through these steps should start up a working instance of react-dash

Install yarn:
a. For Mac: Using homebrew brew install yarn.
b. For Linux: Install yarn by following these steps: https://yarnpkg.com/lang/en/docs/install/#linux-tab
git clone -b update-packages --single-branch [email protected]:NuCivic/react-dash.git react-dash
cd react-dash
yarn install
yarn start

OR if you don't have homebrew or prefer to use npm:

git clone -b update-packages --single-branch [email protected]:NuCivic/react-dash.git react-dash
cd react-dash
npm install
npm start

JayDarnell · 2017-10-10T20:56:41Z

@iris-i - here are my testing results:

`jay@jay-ThinkPad-P50:/workspace$ git clone [email protected]:NuCivic/react-dash.git react-dash
Cloning into 'react-dash'...
remote: Counting objects: 5550, done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 5550 (delta 15), reused 16 (delta 7), pack-reused 5519
Receiving objects: 100% (5550/5550), 11.52 MiB | 2.08 MiB/s, done.
Resolving deltas: 100% (3923/3923), done.
Checking connectivity... done.
jay@jay-ThinkPad-P50:/workspace$ cd react-dash
jay@jay-ThinkPad-P50:~/workspace/react-dash(master)$ npm install
npm WARN peerDependencies The peer dependency react included from react-dash will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react-dom included from react-dash will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN deprecated [email protected]: 🙌 Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
npm WARN engine [email protected]: wanted: {"node":">= 6"} (current: {"node":"4.8.4","npm":"2.15.11"})
npm WARN engine [email protected]: wanted: {"node":"0.10.x"} (current: {"node":"4.8.4","npm":"2.15.11"})
npm WARN peerDependencies The peer dependency react-dom@^15.4.2 included from react-addons-test-utils will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react@^0.14.0 || ^15.0.0-0 included from react-responsive-accordion will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react@^0.14.0 || ^15.0.0-0 included from react-collapsible will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react@^0.14 || ^15.0.0-rc || ^15.0 included from react-input-autosize will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN peerDependencies The peer dependency react@^0.14 || ^15.0.0-rc || ^15.0 included from react-select will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react-dom@^0.14 || ^15.0.0-rc || ^15.0 included from react-select will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN optional dep failed, continuing [email protected]
npm WARN peerDependencies The peer dependency react@^0.14.0 || ^15.0.0 included from react-router will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN optional dep failed, continuing [email protected]

[email protected] install /home/jay/workspace/react-dash/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt
node install.js

PhantomJS not found on PATH
Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Receiving...

[===================================-----] 87%/
Received 22866K total.
Extracting tar contents (via spawned process)
Removing /home/jay/workspace/react-dash/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1507668767957/phantomjs-2.1.1-linux-x86_64 -> /home/jay/workspace/react-dash/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /home/jay/workspace/react-dash/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs

[email protected] install /home/jay/workspace/react-dash/node_modules/node-sass
node scripts/install.js

Cached binary found at /home/jay/.npm/node-sass/3.13.1/linux-x64-46_binding.node

[email protected] postinstall /home/jay/workspace/react-dash/node_modules/node-sass
node scripts/build.js

Binary found at /home/jay/workspace/react-dash/node_modules/node-sass/vendor/linux-x64-46/binding.node
Testing binary
Binary is fine
npm ERR! Linux 4.4.0-96-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install"
npm ERR! node v4.8.4
npm ERR! npm v2.15.11
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants react-dom@>=0.14.0 || ^0.14.0-beta3
npm ERR! peerinvalid Peer [email protected] wants react-dom@>=0.14.0
npm ERR! peerinvalid Peer [email protected] wants react-dom@^0.14 || ^15.0.0-rc || ^15.0
npm ERR! peerinvalid Peer [email protected] wants react-dom@^15.4.2

npm ERR! Please include the following file with any support request:
npm ERR! /home/jay/workspace/react-dash/npm-debug.log
`

iris-i · 2017-10-10T22:40:04Z

@JayDarnell ugh.. Apologies I just updated the testing steps to pull the code from the PR branch not the master branch. Pls try again, it should work now.

JayDarnell · 2017-10-10T22:59:02Z

@iris-i - do forgive my limited npm experience. I removed the react-dash folder created from the previous test and went through the testing steps again. Things look better this time but some dependencies still appear to have been missed.

jay@jay-ThinkPad-P50:/workspace$ git clone -b update-packages --single-branch [email protected]:NuCivic/react-dash.git react-dash
Cloning into 'react-dash'...
remote: Counting objects: 4902, done.
remote: Compressing objects: 100% (47/47), done.
remote: Total 4902 (delta 84), reused 103 (delta 77), pack-reused 4778
Receiving objects: 100% (4902/4902), 10.48 MiB | 6.45 MiB/s, done.
Resolving deltas: 100% (3436/3436), done.
Checking connectivity... done.
jay@jay-ThinkPad-P50:/workspace$ cd react-dash
jay@jay-ThinkPad-P50:~/workspace/react-dash(update-packages)$ npm install
npm WARN deprecated [email protected]: 🙌 Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
npm WARN engine [email protected]: wanted: {"node":"0.10.x"} (current: {"node":"4.8.4","npm":"2.15.11"})
npm WARN engine [email protected]: wanted: {"node":">= 6"} (current: {"node":"4.8.4","npm":"2.15.11"})
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN optional dep failed, continuing [email protected]
npm WARN optional dep failed, continuing [email protected]

[email protected] install /home/jay/workspace/react-dash/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt
node install.js

PhantomJS not found on PATH
Download already available at /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Verified checksum of previously downloaded file
Extracting tar contents (via spawned process)
Removing /home/jay/workspace/react-dash/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2-extract-1507676156055/phantomjs-2.1.1-linux-x86_64 -> /home/jay/workspace/react-dash/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /home/jay/workspace/react-dash/node_modules/karma-phantomjs-launcher/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs
|

[email protected] install /home/jay/workspace/react-dash/node_modules/node-sass
node scripts/install.js

Cached binary found at /home/jay/.npm/node-sass/3.13.1/linux-x64-46_binding.node

[email protected] postinstall /home/jay/workspace/react-dash/node_modules/node-sass
node scripts/build.js

Binary found at /home/jay/workspace/react-dash/node_modules/node-sass/vendor/linux-x64-46/binding.node
Testing binary
Binary is fine
[email protected] node_modules/react-addons-test-utils

[email protected] node_modules/fetch-polyfill

[email protected] node_modules/babel-plugin-transform-object-assign

[email protected] node_modules/json-loader

[email protected] node_modules/colorbrewer

[email protected] node_modules/karma-jasmine

[email protected] node_modules/react-collapsible

[email protected] node_modules/react-responsive-accordion

[email protected] node_modules/classnames

[email protected] node_modules/dkan-es6-data-backend

[email protected] node_modules/csv-es6-data-backend

[email protected] node_modules/geojson

[email protected] node_modules/react-input-autosize

[email protected] node_modules/karma-spec-reporter
└── [email protected]

[email protected] node_modules/file-loader
└── [email protected] ([email protected], [email protected], [email protected], [email protected])

[email protected] node_modules/jasmine-core

[email protected] node_modules/sass-loader
├── [email protected]
├── [email protected]
└── [email protected] ([email protected], [email protected], [email protected])

[email protected] node_modules/eslint-plugin-react

[email protected] node_modules/style-loader
└── [email protected] ([email protected], [email protected], [email protected])

[email protected] node_modules/d3-time-format
└── [email protected]

[email protected] node_modules/extract-text-webpack-plugin
├── [email protected]
├── [email protected] ([email protected], [email protected], [email protected], [email protected])
└── [email protected] ([email protected], [email protected])

[email protected] node_modules/react-select

[email protected] node_modules/babel-preset-react
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] ([email protected])
└── [email protected] ([email protected])

[email protected] node_modules/babel-loader
├── [email protected]
├── [email protected] ([email protected], [email protected], [email protected])
├── [email protected] ([email protected])
└── [email protected] ([email protected], [email protected])

[email protected] node_modules/babel-plugin-transform-class-properties
├── [email protected]
├── [email protected] ([email protected], [email protected], [email protected])
└── [email protected] ([email protected], [email protected], [email protected])

[email protected] node_modules/bootstrap

[email protected] node_modules/babel-preset-stage-0
├── [email protected] ([email protected])
├── [email protected] ([email protected])
└── [email protected] ([email protected], [email protected], [email protected])

[email protected] node_modules/react-router
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] ([email protected])
└── [email protected] ([email protected], [email protected], [email protected])

[email protected] node_modules/react-nvd3
└── [email protected]

[email protected] node_modules/d3

[email protected] node_modules/karma-phantomjs-launcher
└── [email protected] ([email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected])

[email protected] node_modules/karma-webpack
├── [email protected]
├── [email protected] ([email protected], [email protected], [email protected], [email protected])
├── [email protected] ([email protected])
├── [email protected] ([email protected], [email protected], [email protected], [email protected], [email protected])
└── [email protected]

[email protected] node_modules/topojson
├── [email protected]
├── [email protected]
├── [email protected] ([email protected])
├── [email protected] ([email protected], [email protected])
└── [email protected] ([email protected])

[email protected] node_modules/lodash

[email protected] node_modules/flux
├── [email protected]
├── [email protected] ([email protected], [email protected], [email protected])
└── [email protected] ([email protected])

[email protected] node_modules/react
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] ([email protected])
└── [email protected] ([email protected], [email protected], [email protected], [email protected], [email protected])

[email protected] node_modules/react-hot-loader
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] ([email protected], [email protected])
├── [email protected] ([email protected], [email protected], [email protected])
└── [email protected] ([email protected], [email protected], [email protected], [email protected])

[email protected] node_modules/fixed-data-table
└── [email protected] ([email protected], [email protected], [email protected])

[email protected] node_modules/fixed-data-table-2
├── [email protected] ([email protected], [email protected], [email protected])
└── [email protected] ([email protected], [email protected], [email protected])

[email protected] node_modules/react-dom
├── [email protected]
├── [email protected]
├── [email protected] ([email protected])
└── [email protected] ([email protected], [email protected], [email protected], [email protected], [email protected])

[email protected] node_modules/babel-polyfill
├── [email protected]
└── [email protected]

[email protected] node_modules/babel-runtime
├── [email protected]
└── [email protected]
jay@jay-ThinkPad-P50:~/workspace/react-dash(update-packages)$ npm start

[email protected] start /home/jay/workspace/react-dash
bash scripts/start.sh

ENV undefined
INDEX PATH ./examples/index.js
module.js:327
throw err;
^

Error: Cannot find module 'minimist'
at Function.Module._resolveFilename (module.js:325:15)
at Function.Module._load (module.js:276:25)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object. (/home/jay/workspace/react-dash/server.js:5:12)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10)

npm ERR! Linux 4.4.0-96-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
npm ERR! node v4.8.4
npm ERR! npm v2.15.11
npm ERR! code ELIFECYCLE
npm ERR! [email protected] start: bash scripts/start.sh
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script 'bash scripts/start.sh'.
npm ERR! This is most likely a problem with the react-dash package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! bash scripts/start.sh
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs react-dash
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR! npm owner ls react-dash
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /home/jay/workspace/react-dash/npm-debug.log

iris-i mentioned this issue Oct 8, 2017

STORY: Tasks required before the next React-dash Release #68

Open

kimwdavidson added Needs Spec To Do and removed Needs Spec labels Oct 9, 2017

kimwdavidson assigned iris-i Oct 9, 2017

iris-i added In Progress and removed To Do labels Oct 10, 2017

iris-i mentioned this issue Oct 10, 2017

Update packages #83

Merged

iris-i added Code Review and removed In Progress labels Oct 10, 2017

iris-i mentioned this issue Oct 10, 2017

Add packages as dev-dependencies to prevent builds from breaking #70

Closed

iris-i removed their assignment Oct 10, 2017

kimwdavidson assigned JayDarnell Oct 10, 2017

JayDarnell assigned iris-i and unassigned JayDarnell Oct 10, 2017

iris-i assigned JayDarnell and unassigned iris-i Oct 10, 2017

iris-i added In Progress and removed Code Review labels Oct 11, 2017

iris-i assigned iris-i and unassigned JayDarnell Oct 11, 2017

iris-i added Code Review Internal QA and removed In Progress Code Review labels Oct 13, 2017

kimwdavidson removed the Internal QA label Oct 23, 2017

kimwdavidson added the Deployment Ready label Oct 23, 2017

kimwdavidson closed this as completed Oct 30, 2017

kimwdavidson removed the Deployment Ready label Oct 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pin React-dash to React v.15.6.2 #69

Pin React-dash to React v.15.6.2 #69

iris-i commented Oct 8, 2017 •

edited

Loading

iris-i commented Oct 10, 2017 •

edited

Loading

JayDarnell commented Oct 10, 2017

iris-i commented Oct 10, 2017

JayDarnell commented Oct 10, 2017 •

edited

Loading

Pin React-dash to React v.15.6.2 #69

Pin React-dash to React v.15.6.2 #69

Comments

iris-i commented Oct 8, 2017 • edited Loading

iris-i commented Oct 10, 2017 • edited Loading

Testing Steps:

JayDarnell commented Oct 10, 2017

iris-i commented Oct 10, 2017

JayDarnell commented Oct 10, 2017 • edited Loading

iris-i commented Oct 8, 2017 •

edited

Loading

iris-i commented Oct 10, 2017 •

edited

Loading

JayDarnell commented Oct 10, 2017 •

edited

Loading