You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The "Namespace Delimiter" field is ignored, always using "." as namespace delimiter.
To Reproduce
Install SDG panel in Grafana using the provided release bundle "novatec-sdg-panel-4.1.1-release.zip" (uncompress zip and copy novatec-sdg-panel folder into C:\Grafana\data\plugins folder).
Restart Grafana and check it is properly listed and loaded in Grafana / Plugins / Service Dependency Graph
Create a dashboard with an SDG panel, add a query for your data with 'FORMAT AS: Table', specify column names for the desired fields in "Connection Mapping" and "Data Mapping". So far so good, the graph shows nodes and connections properly.
Specify the column name to use for "Namespace Column".
Enter "_" as the "Namespace Delimiter" string (despite the field placeholder says "Enter column name...").
The graph will still use "." as namespace delimiter, not honoring the entered value. This leads to an incorrect / too high number of layers.
Example:
Screenshots
(sorry, no screenshot of the panel due to containing sensitive information)
Your Setup:
OS Grafana is running on: Windows Server 2019 Datacenter
OS & Browser from which Grafana is accessed: Windows 11, Firefox 122
Plugin-Version: 4.1.1-release (displays as 4.0.3 in Grafana / Plugins, but this is a different issue)
Grafana-Version: v8.3.6
Datasource & Version: Custom data from InfluxDB table
Additional context
Inspecting the code, it seems that both "nameSpaceDelimiter" and "namespaceDelimiter" from the dataMapping structure are referred to.
My proposal would be to use "namespaceDelimiter" in all places, in consonance with the "Namespace Delimiter" caption and because namespace is a single word, like Firefox or nonetheless. :)
Thank you!
Jose
The text was updated successfully, but these errors were encountered:
JoseAPortilloJSC
changed the title
[BUG] - Different variable names used for namespaceDelimiter
[BUG] - Namespace Delimiter field in Connection Mapping not honored
Feb 5, 2024
Describe the bug
The "Namespace Delimiter" field is ignored, always using "." as namespace delimiter.
To Reproduce
Install SDG panel in Grafana using the provided release bundle "novatec-sdg-panel-4.1.1-release.zip" (uncompress zip and copy novatec-sdg-panel folder into C:\Grafana\data\plugins folder).
Restart Grafana and check it is properly listed and loaded in Grafana / Plugins / Service Dependency Graph
Create a dashboard with an SDG panel, add a query for your data with 'FORMAT AS: Table', specify column names for the desired fields in "Connection Mapping" and "Data Mapping". So far so good, the graph shows nodes and connections properly.
Specify the column name to use for "Namespace Column".
Enter "_" as the "Namespace Delimiter" string (despite the field placeholder says "Enter column name...").
The graph will still use "." as namespace delimiter, not honoring the entered value. This leads to an incorrect / too high number of layers.
Example:
Expected behavior
Example:
Screenshots
(sorry, no screenshot of the panel due to containing sensitive information)
Your Setup:
Additional context
Inspecting the code, it seems that both "nameSpaceDelimiter" and "namespaceDelimiter" from the dataMapping structure are referred to.
My proposal would be to use "namespaceDelimiter" in all places, in consonance with the "Namespace Delimiter" caption and because namespace is a single word, like Firefox or nonetheless. :)
Thank you!
Jose
The text was updated successfully, but these errors were encountered: