Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to find keys of command XREADGROUP #186

Closed
zyhuf opened this issue Aug 31, 2023 · 2 comments · Fixed by #187
Closed

Failed to find keys of command XREADGROUP #186

zyhuf opened this issue Aug 31, 2023 · 2 comments · Fixed by #187
Assignees

Comments

@zyhuf
Copy link

zyhuf commented Aug 31, 2023

The following command is throwing an error. Why isn't this format supported?
XREADGROUP GROUP XX XX COUNT 1 STREAMS XX >

@zuiderkwast
Copy link
Collaborator

Thanks for the report.

We use a Python script to extract the syntax of each command given in Redis JSON files. Then we turn this into a C array and we have some C code to find the keys in a command based on this.

In XREADGROUP, the keys are not in a fixed position, but it's located after the 'STREAMS' keyword, which can be in any position of the command. That's probably why we don't handle this yet, but I don't remember exactly.

@zuiderkwast
Copy link
Collaborator

There is special code for XREAD and XREADGROUP but it was untested and obviously it wasn't working.

I'm fixing it and adding a test case in #187.

@zuiderkwast zuiderkwast self-assigned this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants