Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the library to SLF4J 2.0 #140

Open
LionZXY opened this issue May 1, 2024 · 1 comment
Open

Update the library to SLF4J 2.0 #140

LionZXY opened this issue May 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@LionZXY
Copy link
Contributor

LionZXY commented May 1, 2024

Background

Right now the library is using <2 version of slf4j. This seems wrong to me, as the current version of slf4j is > 2.0.

So I have two questions:

  • Why decided to use slf4j instead of the past self-described logging system?
  • What to do with the abandoned slf4j-timber project that prevents me from upgrading to slf4j 2.0? I created a PR to upgrade slf4j-timber to 2.0, but I'm afraid the author has already abandoned the project. Would you agree to use fork?
@philips77
Copy link
Member

Hello,

If you'd release an updated version of SLF4J-Timber with updated SLF4J version, that would be amazing. I can migrate to use the latest version, but please also release it on Maven Central.

Why decided to use slf4j instead of the past self-described logging system?

We decided not to reinvent the wheel and use something already existing with more features. Also, I had to fix dependency issues and uncouple BLEK from the Nordic Common library, which should in theory only be used for our sample apps, without forcing people to use it, actually, if that's not required.

We've been already using SLF4J in nRF Connect Device Manager app and I liked how easily can be integrated with Timber or even released as non-android library.

@philips77 philips77 added the enhancement New feature or request label May 3, 2024
philips77 added a commit that referenced this issue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants