Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure type names are generated uniformly independent of capitalization #28

Open
tnull opened this issue Sep 19, 2023 · 2 comments
Open
Labels
bug Something isn't working

Comments

@tnull
Copy link

tnull commented Sep 19, 2023

I have a type declared as interface ASDFObject in my UDL file, which works without issue in Swift/Kotlin/Python.

When trying to generate CS bindings, the output file however includes

public class AsdfObjectSafeHandle: FFISafeHandle {

while the constructors then are defined as

public static extern ASDFObjectSafeHandle ... 

... which of course doesn't compile. If I switch the Rust/UDL type name to be AsdfObject everything seems to be generated uniformly, which I however would like to avoid.

@arg0d
Copy link
Collaborator

arg0d commented Sep 19, 2023

Good catch. Is the expected class name for your C# bindings class AsdfObject? Or should it be class ASDFObject?

@tnull
Copy link
Author

tnull commented Sep 19, 2023

Good catch. Is the expected class name for your C# bindings class AsdfObject? Or should it be class ASDFObject?

I honestly have no strong preference as long as it's consistent and roughly follows the target language's best practices. I'm not too familiar with C# so far, but from what I gathered AsdfObject seems to be the convention?

dennisreimann added a commit to dennisreimann/ldk-node that referenced this issue Sep 20, 2023
@arg0d arg0d added the bug Something isn't working label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants