Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore ways to avoid id clashes of upgradeable modules #814

Open
alcuadrado opened this issue Sep 23, 2024 · 0 comments
Open

Explore ways to avoid id clashes of upgradeable modules #814

alcuadrado opened this issue Sep 23, 2024 · 0 comments
Assignees
Labels
type:improvement An enhancement to an existing feature

Comments

@alcuadrado
Copy link
Member

Describe the feature

When deploying an upgradeable contract using a proxy, the typical way to do it would look something like this:

const proxy = m.contract('Proxy')
const implementation = m.contract('ContractName')
// ...
const proxyWithImplementationABI = m.contractAt('ContractName', proxy)

This leads to a clash between the ids of implementation and proxyWithImplementationABI.

We could probably do better. For example, by changing a bit how contract and contractAt automatic ids are created.

The main issue would be how to do it in a backwards-compatible way.

Search terms

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement An enhancement to an existing feature
Projects
Status: Todo
Development

No branches or pull requests

2 participants