Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce FFI roundtrips when generating Solidity stack trace for requests #682

Open
3 tasks
Xanewok opened this issue Sep 25, 2024 · 0 comments
Open
3 tasks

Comments

@Xanewok
Copy link
Contributor

Xanewok commented Sep 25, 2024

Currently, there's a lot of back and forth going on between the EDR and Hardhat when we generate a Solidity stack trace for a response that results with an error. Since we now have ported the relevant logic to Rust and released it in Hardhat 2.22.12, we can collapse the paths we take in order to generate the user-facing trace.

We roughly need to:

  • Move ContractsIdentifier/VmTraceDecoder into the EDR and add support for adding compilation artifacts via the existing hardhat_addCompilationResult
  • Adapt the TS test code to rely less on the currently exported classes and/or rewrite the relevant test in Rust
  • Collapse the paths and add a generated SolidityStackTrace entry to the existing Response in the provider

EDR TS data flow(2)(1)

@Xanewok Xanewok added this to the Solidity tracing port milestone Sep 25, 2024
@Xanewok Xanewok self-assigned this Sep 25, 2024
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Sep 25, 2024
@Xanewok Xanewok moved this from Unconfirmed to In Progress in EDR Sep 30, 2024
@Xanewok Xanewok removed their assignment Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant