Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiredis still listed as dependency in the NPM package [email protected] #58

Open
BrettStrongEH opened this issue Mar 2, 2020 · 3 comments

Comments

@BrettStrongEH
Copy link

As noted in the issue title, the package.json file obtained during installing this package via the npm command ...
npm i [email protected] OR npm i redis-parser@latest
... still contains a reference to the hiredis dependancy.

According to your change log (and actually from what I can see in your repo in latest version of master branch) this dependency has completely been removed.

Any plans to make the npm v3.0.0 package consistent with whats in your repo?

Cheers for the support.

@BrettStrongEH
Copy link
Author

additional note ... as of node v12 and breaking change with the NaN library cause the compile errors when hiredis attempts to download and install.

@nitinet
Copy link

nitinet commented Mar 13, 2020

Please update the package to latest master branch

@ropre4
Copy link

ropre4 commented Jun 8, 2021

It's been over a year, can there be a new release to include this fix? redis-parser, and redis packages do not work on node 12 and node 14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants