Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark Mode Feature #3

Closed
Nktech-Official opened this issue Oct 14, 2021 · 7 comments · Fixed by #5
Closed

Add Dark Mode Feature #3

Nktech-Official opened this issue Oct 14, 2021 · 7 comments · Fixed by #5
Assignees
Labels
hacktoberfest This issue is participating in Hacktoberfest hacktoberfest-accepted Solving thiss issue will count in Hacktoberfest Type: Add Feture add new feture to the existing app

Comments

@Nktech-Official
Copy link
Owner

add a button in Navbar to enable Dark Mode. So that players can play this game at night. Don't add skip using Black(0,0,0). Color
Make it look like professional Dark-Mode. like Github or any other website take inspiration from where ever you want. Comment and with to assign this issue to you.

@Nktech-Official Nktech-Official added hacktoberfest This issue is participating in Hacktoberfest hacktoberfest-accepted Solving thiss issue will count in Hacktoberfest Type: Add Feture add new feture to the existing app labels Oct 14, 2021
@killerkc12
Copy link
Contributor

I would like to work on this

@killerkc12
Copy link
Contributor

Screenshot (154)
Screenshot (155)

Made the Dark Mode feature like this, if you assigned me the issue, I would like to the send the pull request.

@Nktech-Official
Copy link
Owner Author

One Issue Highlight the active page like when you open home home-tab must have a different color like Green by default when you navigate to another page That page should be highlighted see demo

@Nktech-Official Nktech-Official linked a pull request Oct 15, 2021 that will close this issue
@Nktech-Official
Copy link
Owner Author

@killerkc12 see if you can make it otherwise I will go with the aleardy linked pull request which still need some changes who ever did it first will get merged and the other will not

@Nktech-Official Nktech-Official pinned this issue Oct 15, 2021
@killerkc12
Copy link
Contributor

One Issue Highlight the active page like when you open home home-tab must have a different color like Green by default when you navigate to another page That page should be highlighted see demo

I'll make it, just give me the some time

@killerkc12
Copy link
Contributor

@killerkc12 see if you can make it otherwise I will go with the aleardy linked pull request which still need some changes who ever did it first will get merged and the other will not

In just time I'll make the pr

@killerkc12
Copy link
Contributor

Screenshot (157)
Screenshot (156)

Also I've use the user localstorage for user prefereced theme

@Nktech-Official Nktech-Official linked a pull request Oct 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue is participating in Hacktoberfest hacktoberfest-accepted Solving thiss issue will count in Hacktoberfest Type: Add Feture add new feture to the existing app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants