-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: raise error for gaps in series #504
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Experiment ResultsExperiment 1: air-passengersDescription:
Results:
Plot:Experiment 2: air-passengersDescription:
Results:
Plot:Experiment 3: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 4: electricity-multiple-seriesDescription:
Results:
Plot:Experiment 5: electricity-multiple-seriesDescription:
Results:
Plot: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments, for the comment about the addition to the notebooks in the capabilities, that one might also be appropriate in the tutorial 12_irregular
"\n", | ||
"# Forecast\n", | ||
"# We use B for the freq, as only business days are represented in the dataset\n", | ||
"forecast_df = nixtla_client.forecast(\n", | ||
" df=df, \n", | ||
" df=df,\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a callout to this capabilities notebook at the bottom stating that TimeGPT doesn't allow gaps in the timestamps? E.g.
"Make sure there are no gaps in your time series data. This means that even if the chosen frequency is irregular, you should still make sure you provide a value for every irregular timestamp in the data. For example, if your frequency is "B" (business day), there can't be a gap (missing datapoint) between two consecutive business days."
Edit: perhaps add a similar comment also to the beginning or end of the tutorial notebook 12_irregular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have that in the data requirements notebook
When using TimeGPT, the data cannot contain missing values. This means that for every series, there should be no gaps in the timestamps and no missing values in the target variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but repetition is the key to education? 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that may help, but I'd prefer to add a link to that section instead, otherwise we'll have to remember to change that in every place we set it and will most likely miss some.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small non-blocking comments
Raises an error when the series' timestamps have gaps in them, are duplicated or don't match the specified frequency (
freq
argument).