Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binwalk: 2.4.3 -> 3.1.0 #357991

Merged
merged 1 commit into from
Nov 26, 2024
Merged

binwalk: 2.4.3 -> 3.1.0 #357991

merged 1 commit into from
Nov 26, 2024

Conversation

felbinger
Copy link
Member

@felbinger felbinger commented Nov 21, 2024 •
edited
Loading

Complete re-write in Rust!

  • Significantly faster
  • Far fewer false positives
  • Support for many more file extractors

What's Changed

Full Changelog: ReFirmLabs/binwalk@v2.3.4...v3.1.0

closes #350300

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@felbinger felbinger force-pushed the update-binwalk branch 3 times, most recently from 9ecf11d to 7c6933b Compare November 21, 2024 21:02
@felbinger felbinger marked this pull request as ready for review November 21, 2024 21:07
@nix-owners nix-owners bot requested a review from natsukium November 21, 2024 21:09
@felbinger
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357991

x86_64-linux

✅ 6 packages built:
  • binwalk
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • garble
  • ghidra-extensions.ghidraninja-ghidra-scripts

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 21, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 22, 2024
@ofborg ofborg bot added 8.has: clean-up and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 24, 2024
SuperSandro2000
SuperSandro2000 reviewed Nov 24, 2024
View reviewed changes
nixos/doc/manual/release-notes/rl-2505.section.md Outdated Show resolved Hide resolved
pkgs/by-name/bi/binwalk/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/bi/binwalk/package.nix Outdated Show resolved Hide resolved
@felbinger
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 357991

x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 6 packages built:
  • binwalk
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • garble
  • ghidra-extensions.ghidraninja-ghidra-scripts

@SuperSandro2000 SuperSandro2000 merged commit cbe4fa7 into NixOS:master Nov 26, 2024
34 of 35 checks passed
@felbinger felbinger deleted the update-binwalk branch November 27, 2024 07:43
@devttys0 devttys0 mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@danielfullmer danielfullmer Awaiting requested review from danielfullmer

@dezgeg dezgeg Awaiting requested review from dezgeg

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump binwalk to v3
2 participants
@felbinger @SuperSandro2000