Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meilisearch: migrate to the new macOS SDK #357277

Merged
merged 1 commit into from
Nov 19, 2024
Merged

meilisearch: migrate to the new macOS SDK #357277

merged 1 commit into from
Nov 19, 2024

Conversation

sandydoo
Copy link
Contributor

@sandydoo sandydoo commented Nov 19, 2024 •
edited
Loading

Switches meilisearch to the new macOS SDK pattern.

Fixes the x86_64-darwin build, where we need to link against apple-sdk_11 for the _kCFURLVolumeAvailableCapacityForImportantUsageKey symbol.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sandydoo sandydoo mentioned this pull request Nov 19, 2024
Open
9 tasks
getchoo
getchoo approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of #354146

@getchoo getchoo added 6.topic: darwin Running or building packages on Darwin 0.kind: build failure A package fails to build 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-24.11 Backport PR automatically labels Nov 19, 2024
@sandydoo
Copy link
Contributor Author

Switched lib.optionals -> lib.optional.

@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 19, 2024
@domenkozar domenkozar merged commit f1f2075 into NixOS:master Nov 19, 2024
11 of 12 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

Assignees
No one assigned
Labels
0.kind: build failure A package fails to build 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandydoo @getchoo @domenkozar