bite: migrate to new apple-sdk pattern #355556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
vinnymeller
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
testing to make sure this pr worked i realized bite is marked broken on x86_64 darwin (must have missed that) but also that it wasn't working on aarch64-darwin (unrelated to this pr)
have a draft (#355807) that updates to the latest version, which seems to fix the issues on (aarch64) darwin, as well as incorporates these darwin changes
don't care either way if we want to update the darwin stuff and update separately or just use mine
|
I'm happy to cancel this for a superseding PR. Feel free to tag me as a reviewer. |
|
Superseded by #355807 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed explicit references to darwin.apple_sdk.frameworks as they're no longer needed.
Tracking: #354146
Superseded by #355807
Note: Nixpkgs-review currently fails due to #355519
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.