Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings commandLineArgs on an overlay for vscode breaks the ability to open files thru the cli with it #357956

Open
stereomato opened this issue Nov 21, 2024 · 5 comments
Labels
0.kind: bug Something is broken

Comments

@stereomato
Copy link

Describe the bug

I sometimes open vscode by doing code $someFile, and noticed this doesn't work now. I copied the script that launches vscode, removed the cmd line arg I add thru the overlay, and that way it works normally.

Steps To Reproduce

Steps to reproduce the behavior:

  1. create an overlay and add something like "--disable-font-subpixel-positioning" on commandLineArgs
  2. try to open file with code $someFile
  3. new vscode window opens, but no file is ever loaded. Same behavior with folders.

Expected behavior

Specified file/folders are opened in vscode

Metadata

  • system: "x86_64-linux"
  • host os: Linux 6.12.0, NixOS, 25.05 (Warbler), 25.05.20241119.23e89b7
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.24.10
  • nixpkgs: /nix/store/c9wv7i0af6mysmy65x6nvyfw5izzxv4g-source

Notify maintainers

@eadwu @Synthetica9 @JohnRTitor @bobby285271

Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@stereomato stereomato added the 0.kind: bug Something is broken label Nov 21, 2024
@JohnRTitor
Copy link
Contributor

Can't seem to reproduce this with this in environment.systemPackages

  (pkgs.vscode.override {
    # if keyring does not work, try either "libsecret" or "gnome"
    commandLineArgs = ''--password-store=gnome-libsecret'';
  })

@stereomato
Copy link
Author

Can't seem to reproduce this with this in environment.systemPackages

  (pkgs.vscode.override {
    # if keyring does not work, try either "libsecret" or "gnome"
    commandLineArgs = ''--password-store=gnome-libsecret'';
  })

huh, that's weird. I have an overlay on nixpkgs.overlay for my user with home-manager as a module. how does the script for vscode look like for you? I've no idea what's going on

@stereomato
Copy link
Author

alright, this might be an issue specific to the flag I'm using. tried yours and it works fine, as soon as i add the one i use, it fails to open files thru the cli

@JohnRTitor
Copy link
Contributor

A good way to test this would be:

nix-shell -p vscode
code --disable-font-subpixel-positioning hello.txt

@stereomato
Copy link
Author

stereomato commented Nov 21, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

2 participants