Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-24.11 no ordering with samba module settings #357829

Open
kkt4 opened this issue Nov 21, 2024 · 0 comments
Open

nixos-24.11 no ordering with samba module settings #357829

kkt4 opened this issue Nov 21, 2024 · 0 comments
Labels
0.kind: bug Something is broken

Comments

@kkt4
Copy link

kkt4 commented Nov 21, 2024

Describe the bug

It seems https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/network-filesystems/samba.nix was changed after 24.05 to respect https://github.com/NixOS/rfcs/blob/master/rfcs/0042-config-option.md. But some smb.conf options have a dependency of order (include=...). This option (as per doc) "[...] allows you to include one config file inside another. The file is included literally, as though typed in place." There doesn't seem to be a way to order parameters anymore. Looks like parameters are just ordered lexically now.

Steps To Reproduce

services.samba = {
  enable = true;
  settings = {
    global = {
      security = "user";
      include = "/etc/smb2.conf";
    };
  };
};

gives

[global]
include = /etc/smb2.conf
security = "user";

Expected behavior

[global]
security = "user";
include=/etc/smb2.conf

Notify maintainers

@anthonyroussel @bachp


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@kkt4 kkt4 added the 0.kind: bug Something is broken label Nov 21, 2024
@kkt4 kkt4 changed the title nixos-24.11 problem with samba module nixos-24.11 no ordering with samba module settings Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

1 participant