Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression?] nix repl: ctrl-c behaviour? #2743

Closed
xbreak opened this issue Mar 24, 2019 · 0 comments · Fixed by #2767
Closed

[regression?] nix repl: ctrl-c behaviour? #2743

xbreak opened this issue Mar 24, 2019 · 0 comments · Fixed by #2767

Comments

@xbreak
Copy link
Contributor

xbreak commented Mar 24, 2019

It seems that when the nix repl went from using readline -> linenoise -> editline it lost the ctrl-c behaviour of aborting partially typed expressions. Example:

Welcome to Nix version 2.3. Type :? for help.

nix-repl> let foo = 1;
          in
          ^C
          ^C

I guess this was not intentional since more or less identical issues have been addressed previously (c.f. #1757, #2076). Currently it looks like the ctrl-c behaviour was last lost in PR #2228.

I have prepared a fix here https://github.com/xbreak/nix/tree/repl/ctrlc which sort of cherry picks from the previous solution when readline was used. I can create a PR if the approach look ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant