Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flexbox with gap instead of margins #204

Closed
Ronef opened this issue May 24, 2023 · 3 comments
Closed

Use flexbox with gap instead of margins #204

Ronef opened this issue May 24, 2023 · 3 comments

Comments

@Ronef
Copy link
Contributor

Ronef commented May 24, 2023

For now each icon has own margins for each size + parent container has related negative margins.

It can be replaced by modern display: inline-flex; and gap, which is more convenient and powerful.

For example, column orientation #72 will be implemented in this case by just one rule: flex-direction: column;.
@NikolayRys
Copy link
Owner

Do you want to make a PR?

@Ronef
Copy link
Contributor Author

Ronef commented May 25, 2023

@NikolayRys
Ok, i'll try to do it ASAP.

@Ronef
Copy link
Contributor Author

Ronef commented May 25, 2023 •
edited
Loading

@NikolayRys
PR #205

@Ronef Ronef closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ronef @NikolayRys