Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prev/Next not responding #14

Open
duongtunglam opened this issue Oct 10, 2013 · 5 comments
Open

Prev/Next not responding #14

duongtunglam opened this issue Oct 10, 2013 · 5 comments
Labels

Comments

@duongtunglam
Copy link

On my device, android 4.1.2, I touch on Prev/Next and nothing happened. Please fix.

@NikolajDL
Copy link
Owner

Thank you for the report. I'll look into the issue.

@SWORDBASEDGOD
Copy link

Has there been anything done to solve this issue? I am working on a project and the touch nav buttons are not working on mobile platforms.(phones or tablets) i have even thought or tried to modify the html adding buttons on top of the containing div and then calling the prev and next function... but i cant seem to get that working due to not knowing Jquery very well. im also new to this site and not sure if i need to post this here in hopes or if i need to put a pull request in for this.

Anyways thanks in advance!

@SWORDBASEDGOD
Copy link

i was able to find the answer...
To get this to work on touch devices such as tablets and phones add this code after line 120 in the jquery.excoloSlider.js file.

$prev.on("touchstart", function (e) { base.previous(); });
$next.on("touchstart", function (e) { base.next(); });

@NikolajDL
Copy link
Owner

Thank you very much. The reason the project has been still for a while, is because I'm considering rewriting the whole thing since my Javascript experience has increased quite a bit, since I initiated the project.

@venturalp
Copy link

Thanks @SWORDBASEDGOD I used your code, but I made some improvement, at least for me this solved a little better my problem, so at the same lines I put:

$prev.on("touchstart click", function (e) { base.previous(); }); $next.on("touchstart click", function (e) { base.next(); }); $prev.on("touchend", function (e) {e.stopPropagation(); }); $next.on("touchend", function (e) {e.stopPropagation();});

'Cause without stopping touchend propagation, next and prev buttons were just working if I keep my finger pressed until the slide change. At the beginning I thought that it would disable swipe gestures, but it doesn't, so I guess it's a good workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants