-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rack v2 #14
Comments
I kinda left them to collect dust, as they were not very popular. But since there is at least one user, I might convert them then. :) Will keep you updated. |
That would be great, thanks! |
For what it’s worth - at least one other user on the community forum is keen to see your modules make the transition, I suspect there would be a few others. |
I have just made the source-code open-source. Someone has already offered to port it to Rack v2. The code does not have lots of comments, and those that are there might be outdated. And sorry for all the IF statements in Bass module. Probably not much fun to read that code. |
I just built your plugin out of curiosity. Are you sure you don't want to maintain control of your plugin? It transferred to v2 literally by changing the rack version in plugin.json to 2.0.0 |
Oh? I thought it would require tons of deep changes, didn't look into it. Since I open-sourced it a couple of hours ago, I actually toyed with the idea of continue to work on it. Must admit. Don't know, I said Steve Russell could have it. Not sure if he planned to just update it to v2 or do other stuff with it. |
I was just going to port it over to v2 for the time being. Looks like there wasn't anything to do in the way of API changes as @pgatt mentioned in his post. That saves me some work! lol I'd like to extend my thanks to you as well for opensourcing your modules as I'm a old user as well - what's that 3 of us now? Haha Would be great if you continued to work on them when you can, although as a reminder you would have to add me as a repo Contributor - that way I could commit directly to the codebase. Otherwise you would have to see and merge manually any PR I or someone else makes. |
@NikolaiVChr, Up to you either way, just thought I would let you know as it was only a one line fix - I have a Mac and can build for you if necessary, but there are workarounds too - I believe some devs have done a few different methods to achieve this, if I recall corrrectly one dev even uses Github actions to build for the other two platforms that he doesn't have. |
That sounds interesting, I will look into that. And thank you for the offer. I am doing the conversion to Rack v2 now. |
I got the github actions to work now. Both for Rack v1 and for Rack v2 branches. V2 is built using rack beta 1 SDK. |
v2.0.0 is now released. And I have notified VCV Rack to include it in the library as open-source. |
Hi there,
I use your modules a bunch in Rack v1, just wondering if you are going to convert them over to VCV 2?
Thanks!
The text was updated successfully, but these errors were encountered: