Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling a Detector appears to have changed. #103

Open
greatestusername opened this issue Apr 25, 2019 · 0 comments
Open

Disabling a Detector appears to have changed. #103

greatestusername opened this issue Apr 25, 2019 · 0 comments

Comments

@greatestusername
Copy link
Contributor

Issue:
Disabling a detector no longer works.

Suspected Cause:
API change on SFX side. We used to pass in disabled:disabled as an option for a detector to disable it.
https://github.com/Nike-Inc/signal_analog/blob/master/signal_analog/detectors.py#L270-L280

Now it appears disabling a detector is with a PUT to /detector/{id}/disable
https://developers.signalfx.com/detectors_reference.html#tag/Disable-Single-Detector

We will need to refactor to grab the id for the matching detector to be disabled and hit that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant