Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'acc-role' profile naming should support other delimiters #474

Open
mjreed-wbd opened this issue Sep 5, 2024 · 0 comments
Open

'acc-role' profile naming should support other delimiters #474

mjreed-wbd opened this issue Sep 5, 2024 · 0 comments

Comments

@mjreed-wbd
Copy link
Contributor

Expected Behavior

With cred_profile set to acc:role, generated profile names should be of the form $account:$role, likewise for acc/role, acc_role, or any other delimiter character.

Current Behavior

Only acc-role is special; any other accXrole string becomes the literal role name.

Possible Solution

Look for the pattern accXrole instead of the literal string 'acc-role' and if it matches use the character in position 3 as the delimiter when creating the role name.

Context

Before gimme-aws-creds we used a homegrown tool that created profiles of the form account:role. When we first switched to gimme-aws-creds, we needed some local customizations to support our security policies, so we just added the profile name support as part of our fork. Currently, the Nike version has incorporated the security fixes we need, so the only thing missing to let us abandon our fork and use the upstream version is the profile support. Unfortunately, we still have a lot of IaC with hard-coded profile names, which makes it a significant effort to simply adopt a new convention.

Your Environment

  • App Version used: 2.8.2
  • Environment name and version: CPython 3.12.5
  • Operating System and version: macOS 14.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant