Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RM] torchtext as a top-level package #5

Open
ruohoruotsi opened this issue May 28, 2019 · 2 comments
Open

[RM] torchtext as a top-level package #5

ruohoruotsi opened this issue May 28, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ruohoruotsi
Copy link
Member

Remove torchtext as a top-level package. torchtext code was added to the repo as a workaround because:

  • OpenNMT requires the latest torchtext, which must be installed with pip install git+https://github.com/pytorch/text (torchtext=0.4.0)
  • The latest torchtext cannot be installed with pip install torchtext because on PyPI torchtext=0.3.1 is the latest. Using it causes OpenNMT based predictions to BREAK!

Since we cannot accelerate nor predict when torchtext=0.4.0 will be on PyPI, we fold that dependency into a top-level package and carry on with this issue as a reminder to clean up once the correct version is ready.

@ruohoruotsi ruohoruotsi added the bug Something isn't working label May 28, 2019
@ruohoruotsi ruohoruotsi self-assigned this May 28, 2019
@ruohoruotsi
Copy link
Member Author

ruohoruotsi commented May 28, 2019

23a6dda, 4cd125f

@ruohoruotsi
Copy link
Member Author

https://pypi.org/project/torchtext/ is now at version 0.6 @Timilehin , this should be ready to go!
Also does https://pypi.org/project/OpenNMT-py/ even require torchtext anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants