Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon using invisible name being deleted #150

Open
thel0thric opened this issue Jan 11, 2022 · 1 comment
Open

Pokemon using invisible name being deleted #150

thel0thric opened this issue Jan 11, 2022 · 1 comment

Comments

@thel0thric
Copy link

thel0thric commented Jan 11, 2022

What version of GTS are you running?
GTS-Sponge-6.1.8-SNAPSHOT-250.jar

What version of Sponge are you running?
SpongeForge 1.12.2-2838-7.3.1-RC4082 (when the problem happens as you can see on error log)

To Reproduce

  1. Rename your pokemon using an emoji (utf8)
  2. Try sell the renamed pokemon

Is there a solution?
Based on what was discussed on Discord, I don't know. The player could receive a warning saying that their pokémon contains invalid characters, or just have the pokémon returned and an error message saying that it was not possible to continue the listing.

Maybe working on something like utf8mb4 is possible?

Or just do nothing, delete the report, call me a liar and say that there are no bugs in the GTS because there is nothing in the bugtracker.
(☞ຈل͜ຈ)☞

Error logs
(https://pastebin.com/KWLnf3ds)
I tried to use Gist, but I'm a fucking dumb.

@NickImpact
Copy link
Owner

Additional context, this is a problem only with UTF-8 characters that require 4 bytes, and is an issue with MySQL primarily. For now, the simple solution will be just blocking pokemon named like such. We can explore the encoding upgrade later on with API 8.

But yes, there are no bugs in GTS Sing Se.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants