Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in zahnle_rx_and_thermo_files, that prevents removing particles #35

Open
Nicholaswogan opened this issue Nov 5, 2024 · 0 comments
Open

Bug in zahnle_rx_and_thermo_files, that prevents removing particles #35

Nicholaswogan opened this issue Nov 5, 2024 · 0 comments

Comments

@Nicholaswogan
Copy link
Owner

The function zahnle_rx_and_thermo_files has an option for generating a reaction file without particles, but it doesn't work. It looks like a pretty easy fix. This is the relevant part of the code:

photochem/photochem/utils/_format.py

Line 269 in 511cc82

if 'particles' in dat and not remove_particles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nicholaswogan