Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CalcTWAP: can be reduced to only one snapshots range. #1553

Open
jgimeno opened this issue Aug 23, 2023 · 0 comments · May be fixed by #1801
Open

CalcTWAP: can be reduced to only one snapshots range. #1553

jgimeno opened this issue Aug 23, 2023 · 0 comments · May be fixed by #1801
Labels
good first issue

Comments

@jgimeno
Copy link
Contributor

jgimeno commented Aug 23, 2023 •
edited
Loading

nibiru/x/perp/v2/keeper/twap.go

Lines 50 to 55 in 89b005e

for ; iter.Valid(); iter.Next() {
s := iter.Value()
snapshots = append(snapshots, s)
if s.TimestampMs <= lowerLimitTimestampMs {
break
}

nibiru/x/perp/v2/keeper/twap.go

Line 79 in 89b005e

for _, snapshot := range snapshots {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
⚛️ Nibiru (Hougyoku)
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reduced CalcTWAP to only one snapshots range decentrio/nibiru
3 participants
@jgimeno @k-yang @Unique-Divine