Skip to content
This repository has been archived by the owner on Oct 9, 2022. It is now read-only.

Does it replace the image and url of yt search with spotify url and image? #4

Open
rohank05 opened this issue Sep 1, 2021 · 17 comments
Labels
bug Something isn't working enhancement New feature or request meta: minor

Comments

@rohank05
Copy link

rohank05 commented Sep 1, 2021

The offical plugin does not keep a single spotify thing in result. which is annoying. I was going to write my own package but i wanted to know where it keep it or not

@KagChi KagChi added enhancement New feature or request meta: minor labels Sep 1, 2021
@KagChi
Copy link
Member

KagChi commented Sep 1, 2021

i think we cant replace to resolved track, but we can assign to unresolved one

@KagChi
Copy link
Member

KagChi commented Sep 1, 2021

this feature has been implemented, its recomended using api if trying to get track thumbnail, to use npm i NezuChan/better-erela.js-spotify

@rohank05
Copy link
Author

rohank05 commented Sep 1, 2021

this feature has been implemented, its recomended using api if trying to get track thumbnail

aah thanks

@rohank05
Copy link
Author

rohank05 commented Sep 1, 2021

umm so i tried it and i have a playlist of 148 songs it only register 100. It is also changing the spotify thumbnail to youtube one and url too. I know it gets track data from yt. but thumbnail and url should be original of what user added

@KagChi
Copy link
Member

KagChi commented Sep 1, 2021

what your spotify url?

@KagChi
Copy link
Member

KagChi commented Sep 1, 2021

It is also changing the spotify thumbnail to youtube one and url too. I know it gets track data from yt. but thumbnail and url should be original of what user added

we cant assign to resolved track, way to do this modify erela.js it self

@rohank05
Copy link
Author

rohank05 commented Sep 1, 2021

It is also changing the spotify thumbnail to youtube one and url too. I know it gets track data from yt. but thumbnail and url should be original of what user added

we cant assign to resolved track, way to do this modify erela.js it self

What about it only fetching 100 songs?

@noxzym
Copy link
Contributor

noxzym commented Sep 1, 2021

It is also changing the spotify thumbnail to youtube one and url too. I know it gets track data from yt. but thumbnail and url should be original of what user added

we cant assign to resolved track, way to do this modify erela.js it self

What about it only fetching 100 songs?

gimme the spotify url

@KagChi
Copy link
Member

KagChi commented Sep 1, 2021

It is also changing the spotify thumbnail to youtube one and url too. I know it gets track data from yt. but thumbnail and url should be original of what user added

we cant assign to resolved track, way to do this modify erela.js it self

What about it only fetching 100 songs?

can you share your spotify url?

@rohank05
Copy link
Author

rohank05 commented Sep 1, 2021

It is also changing the spotify thumbnail to youtube one and url too. I know it gets track data from yt. but thumbnail and url should be original of what user added

we cant assign to resolved track, way to do this modify erela.js it self

What about it only fetching 100 songs?

can you share your spotify url?

https://open.spotify.com/playlist/7ed2MAfqUXoLmZj5fIWF3E?si=075d2d2571bc426d

@KagChi KagChi added the bug Something isn't working label Sep 1, 2021
@rohank05
Copy link
Author

rohank05 commented Sep 1, 2021

image
Does this looks fine it gives typeError
Spotify option "playlistPageLimit" must be a number.

@KagChi
Copy link
Member

KagChi commented Sep 1, 2021

image
Does this looks fine it gives typeError
Spotify option "playlistPageLimit" must be a number.

its fine, but i made a mistake while checking the options, will fixed on next release

@KagChi
Copy link
Member

KagChi commented Sep 1, 2021

this fixed with latest commit, you should try.
also set strategy to API if you want to using api instead scrape.
scrape cant load more than 100 tracks

@KagChi
Copy link
Member

KagChi commented Sep 1, 2021

and about spotify metadata, still not fixed

@KagChi
Copy link
Member

KagChi commented Sep 2, 2021

hey, good news!, this feature has been fully implemented.
to apply, set convertUnresolved to true and useSpotifyMetadata to true

@rohank05
Copy link
Author

sorry for being a little late to reply. But i tried convertUnresolved and useSpotifyMetadata both to true. It won't work properly. First it will change the player metadata to spotify but as soon as it enters the current it all becomes YT

@KagChi
Copy link
Member

KagChi commented Sep 11, 2021

I have tried various ways, such as extending the resolve function. but the track still reads like an unresolved track. any solutions? or you can make pr

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request meta: minor
Projects
None yet
Development

No branches or pull requests

3 participants