Ongoing improvements for the phone controller

[f10l]

I did so far:

• Call renamed to phone
• Structure of GET /phone/numbers return improved

Notes about the other endpoints:

• GET /phone/calls endpoint should:

  • validation improved untested
  • a "converterId" by the user who converted the resource would be helpful
  • List also converted calls by the requesting user
  • converted query flag should be boolean
  • What is country, zip, city on the call resource? Is it provided through the number itself?
  • recordUrl would probably be helpful there, will be used later with S3 or so?
  • created should probably be createdAt? make createdAt and modifiedAt consistent #69

• PUT /phone/calls/{sid}/converted:

  • I think this could be a POST /phone/calls/{sid}/help-request endpoint. Reason: a new help-request resource is created
  • The body should contain a full CreateHelpRequestDto, then it would be equal to the general creation of a help request.
  • If not exists: A new user should be created for the this help request
  • The user need a phoneUser flag
  • If this flag is set, the user are not meant for login but only to identify to their phoneNumber

• GET /phone/calls/{sid}/record

  • this is okay in principle, but it would be easier for the App guys if we provide the URL in the call entry itself (using S3 or so then)

• A GET /phone/calls/{sid} endpoint is missing

• Build call relation in the helpRequests: Add call information to HelpRequest model #73

• Add twilio endpoints to swagger

• Use an auth guard for twilio

• Use a class for GET /phone/numbers and think about environment handling

General remark:
I think it is fine to document the twilio webhooks there as well. Probably twilio sends an auth header which should be checked there?