From 793ccd0c4935f2932a94cfc5418ec900d3bb1068 Mon Sep 17 00:00:00 2001
From: sneakers-the-rat <sneakers-the-rat@protonmail.com>
Date: Sat, 12 Oct 2024 21:02:31 -0700
Subject: [PATCH] Working version of fetch all replies service with global
 maximum on fetching

---
 app/controllers/api/v1/statuses_controller.rb |  2 +-
 .../concerns/status/fetch_replies_concern.rb  |  2 +-
 .../activitypub/fetch_all_replies_worker.rb   | 37 +++++++++++++------
 3 files changed, 28 insertions(+), 13 deletions(-)

diff --git a/app/controllers/api/v1/statuses_controller.rb b/app/controllers/api/v1/statuses_controller.rb
index e2adaa796d5c60..985e524070a78d 100644
--- a/app/controllers/api/v1/statuses_controller.rb
+++ b/app/controllers/api/v1/statuses_controller.rb
@@ -62,9 +62,9 @@ def context
     if !current_account.nil? && @status.should_fetch_replies?
       ActivityPub::FetchAllRepliesWorker.perform_async(
         @status.id,
+        current_account.id,
         {
           allow_synchronous_requests: true,
-          current_account_id: current_account.id,
         }
       )
     end
diff --git a/app/models/concerns/status/fetch_replies_concern.rb b/app/models/concerns/status/fetch_replies_concern.rb
index 10ddb71f099b29..696e93ec88555c 100644
--- a/app/models/concerns/status/fetch_replies_concern.rb
+++ b/app/models/concerns/status/fetch_replies_concern.rb
@@ -20,7 +20,7 @@ module Status::FetchRepliesConcern
 
   def should_fetch_replies?
     # we aren't brand new, and we haven't fetched replies since the debounce window
-    !local? && created_at <= 10.minutes.ago && (
+    !local? && created_at <= CREATED_RECENTLY_DEBOUNCE.ago && (
       fetched_replies_at.nil? || fetched_replies_at <= FETCH_REPLIES_DEBOUNCE.ago
     )
   end
diff --git a/app/workers/activitypub/fetch_all_replies_worker.rb b/app/workers/activitypub/fetch_all_replies_worker.rb
index 882faf7dca3a24..af2cf40e91ca1d 100644
--- a/app/workers/activitypub/fetch_all_replies_worker.rb
+++ b/app/workers/activitypub/fetch_all_replies_worker.rb
@@ -7,29 +7,39 @@
 class ActivityPub::FetchAllRepliesWorker
   include Sidekiq::Worker
   include ExponentialBackoff
+  include JsonLdHelper
 
   sidekiq_options queue: 'pull', retry: 3
 
   # Global max replies to fetch per request
   MAX_REPLIES = 1000
 
-  def perform(parent_status_id, options = {})
+  def perform(parent_status_id, current_account_id = nil, options = {})
     @parent_status = Status.find(parent_status_id)
-    @current_account_id = options.fetch(:current_account_id, nil)
-    @current_account = @current_account_id.nil? ? nil : Account.find(id: @current_account_id)
+    @current_account_id = current_account_id
+    @current_account = @current_account_id.nil? ? nil : Account.find(@current_account_id)
+    Rails.logger.debug { "FetchAllRepliesWorker - #{parent_status_id}: Fetching all replies for status: #{@parent_status}" }
 
-    all_replies = get_replies(@parent_status.uri)
+    all_replies = get_replies(@parent_status.uri, options)
     got_replies = all_replies.length
     until all_replies.empty? || got_replies >= MAX_REPLIES
-      new_replies = get_replies(all_replies.pop)
+      next_reply = all_replies.pop
+      next if next_reply.nil?
+
+      new_replies = get_replies(next_reply, options)
+      next if new_replies.nil?
+
       got_replies += new_replies.length
-      all_replies << new_replies
+      all_replies.concat(new_replies)
     end
+
+    Rails.logger.debug { "FetchAllRepliesWorker - #{parent_status_id}: fetched #{got_replies} replies" }
+    got_replies
   end
 
   private
 
-  def get_replies(status_uri)
+  def get_replies(status_uri, options = {})
     replies_uri = get_replies_uri(status_uri)
     return if replies_uri.nil?
 
@@ -37,9 +47,14 @@ def get_replies(status_uri)
   end
 
   def get_replies_uri(parent_status_uri)
-    json_status = fetch_resource(parent_status_uri, true, @current_account)
-    replies_uri = json_status['replies']
-    Rails.logger.debug { "Could not find replies uri for status URI: #{parent_status_uri}" } if replies_uri.nil?
-    replies_uri
+    begin
+      json_status = fetch_resource(parent_status_uri, true, @current_account)
+      replies_uri = json_status['replies']
+      Rails.logger.debug { "FetchAllRepliesWorker - #{@parent_status_id}: replies URI was nil" } if replies_uri.nil?
+      replies_uri
+    rescue => e
+      Rails.logger.error { "FetchAllRepliesWorker - #{@parent_status_id}: Got exception while resolving replies URI: #{e} - #{e.message}" }
+      nil
+    end
   end
 end