Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Numpy 2.0 #1896

Closed
3 tasks done
mavaylon1 opened this issue Apr 29, 2024 · 1 comment
Closed
3 tasks done

[Bug]: Numpy 2.0 #1896

mavaylon1 opened this issue Apr 29, 2024 · 1 comment
Assignees
Labels
category: bug errors in the code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Milestone

Comments

@mavaylon1
Copy link
Collaborator

What happened?

Numpy 2.0 deprecated some functions, leading to tests not passing in the run all tests workflow. The simple fix I have planned in hdmf-zarr/hdmf is to just pin numpy below 2.0 until python 3.8 is deprecated in October. We can then update the deprecations then.

Steps to Reproduce

run all tests workflow

Traceback

No response

Operating System

Windows

Python Executable

Conda

Python Version

lower version (unsupported)

Package Versions

No response

Code of Conduct

@mavaylon1 mavaylon1 self-assigned this Apr 29, 2024
@mavaylon1 mavaylon1 added the category: bug errors in the code or code behavior label Apr 29, 2024
@mavaylon1 mavaylon1 added this to the 2.7.0 milestone Apr 29, 2024
@stephprince stephprince modified the milestones: 2.7.0, 2.8.0 May 9, 2024
@rly rly assigned rly and unassigned mavaylon1 Jun 27, 2024
@stephprince stephprince modified the milestones: 2.8.0, 2.9.0 Jul 23, 2024
@rly rly assigned mavaylon1 and unassigned rly Aug 21, 2024
@rly
Copy link
Contributor

rly commented Aug 21, 2024

HDMF now supports numpy 2.0. @mavaylon1 said that he will bump up the requirements in pynwb to include numpy 2.0 and coordinate with @stephprince on a new bugfix release in the next two weeks.

@rly rly added the priority: low alternative solution already working and/or relevant to only specific user(s) label Aug 21, 2024
@stephprince stephprince modified the milestones: 2.9.0, 2.8.2 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

No branches or pull requests

3 participants