Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Retinotopy classes #1053

Closed
6 tasks
rly opened this issue Aug 28, 2019 · 1 comment · Fixed by #1813
Closed
6 tasks

Clean up Retinotopy classes #1053

rly opened this issue Aug 28, 2019 · 1 comment · Fixed by #1813

Comments

@rly
Copy link
Contributor

rly commented Aug 28, 2019

https://github.com/NeurodataWithoutBorders/pynwb/blob/dev/src/pynwb/retinotopy.py

  • PyNWB requires a unit for the sign_map. unit is not part of the specification for sign_map.
  • PyNWB requires a focal_depth for the vasculature_image. focal_depth is not part of the specification for vasculature_image
  • AImage is not an informative class name
  • AImage should extend GrayscaleImage
  • AxisMap should extend NWBData
  • See also changes proposed in Clean up ImagingRetinotopy type nwb-schema#303
@rly rly mentioned this issue Jan 4, 2024
Merged
6 tasks
@stephprince
Copy link
Contributor

This issue was closed by #1813 which deprecated the ImagingRetinotopy module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate broken ImagingRetinotopy module NeurodataWithoutBorders/pynwb
2 participants
@rly @stephprince