From e8eb9d9deb2b6337da680e68535902d25fcc0f8d Mon Sep 17 00:00:00 2001 From: Cody Baker <51133164+CodyCBakerPhD@users.noreply.github.com> Date: Sun, 25 Aug 2024 23:29:55 -0400 Subject: [PATCH 1/3] explicit email notify --- .github/workflows/dailies.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dailies.yml b/.github/workflows/dailies.yml index 4518ff772..a4b42517c 100644 --- a/.github/workflows/dailies.yml +++ b/.github/workflows/dailies.yml @@ -36,6 +36,6 @@ jobs: username: ${{ secrets.MAIL_USERNAME }} password: ${{ secrets.MAIL_PASSWORD }} subject: NWB Inspector Daily Failure - to: ${{ secrets.DAILY_FAILURE_EMAIL_LIST }} # add more with commas, no separation + to: cody.c.baker.phd@gmail.com from: NWB Inspector body: "The daily workflow for the NWB Inspector failed: please check status at https://github.com/NeurodataWithoutBorders/nwbinspector/actions/workflows/dailies.yml" From c71de75f25f44c44f1e03654b62e7580a1490037 Mon Sep 17 00:00:00 2001 From: Cody Baker <51133164+CodyCBakerPhD@users.noreply.github.com> Date: Sun, 25 Aug 2024 23:30:44 -0400 Subject: [PATCH 2/3] update trigger --- .github/workflows/dailies.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dailies.yml b/.github/workflows/dailies.yml index a4b42517c..9af7f93fe 100644 --- a/.github/workflows/dailies.yml +++ b/.github/workflows/dailies.yml @@ -26,8 +26,8 @@ jobs: notify: runs-on: ubuntu-latest - needs: [run-daily-tests, run-daily-doc-link-checks] - if: ${{ always() && contains(needs.*.result, 'failure') }} + needs: [run-daily-tests, run-daily-doc-link-checks, test-dandi-latest, test-dandi-dev, test-dandi-dev-live] + if: failure() steps: - uses: dawidd6/action-send-mail@v3 with: From 3330336eff994b55668fb4150369cc7f3ec64b88 Mon Sep 17 00:00:00 2001 From: Cody Baker <51133164+CodyCBakerPhD@users.noreply.github.com> Date: Mon, 26 Aug 2024 13:05:31 -0400 Subject: [PATCH 3/3] Update .github/workflows/dailies.yml Co-authored-by: Steph Prince <40640337+stephprince@users.noreply.github.com> --- .github/workflows/dailies.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dailies.yml b/.github/workflows/dailies.yml index 9af7f93fe..0a579039a 100644 --- a/.github/workflows/dailies.yml +++ b/.github/workflows/dailies.yml @@ -36,6 +36,6 @@ jobs: username: ${{ secrets.MAIL_USERNAME }} password: ${{ secrets.MAIL_PASSWORD }} subject: NWB Inspector Daily Failure - to: cody.c.baker.phd@gmail.com + to: cody.c.baker.phd@gmail.com,smprince@lbl.gov from: NWB Inspector body: "The daily workflow for the NWB Inspector failed: please check status at https://github.com/NeurodataWithoutBorders/nwbinspector/actions/workflows/dailies.yml"