Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PyNWB validator not using cached schema #528

Closed
3 tasks done
rly opened this issue Oct 8, 2024 · 0 comments · Fixed by #531
Closed
3 tasks done

[Bug]: PyNWB validator not using cached schema #528

rly opened this issue Oct 8, 2024 · 0 comments · Fixed by #531
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users

Comments

@rly
Copy link
Contributor

rly commented Oct 8, 2024

What happened?

Using the dev branch, the PyNWB validator is not using cached extensions during validation. I think that is because we are using the validate(io=io) method instead of the validate(paths=paths) method.

https://github.com/NeurodataWithoutBorders/nwbinspector/blame/ba7d845b255e8095c72978e91b2c014675ef55d6/src/nwbinspector/_nwb_inspection.py#L277

This appears to have been changed recently to support validation with Zarr.

See also NeurodataWithoutBorders/pynwb#1777

I will look into solutions. We should add a test for this.

Operating System

macOS

Python Version

3.12

Were you streaming with ROS3?

No

Package Versions

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • Have you ensured this bug was not already reported?
  • To the best of your ability, have you ensured this is a bug within the code that checks the NWBFile, rather than a bug in the NWBFile reader (e.g., PyNWB or MatNWB)?
@rly rly added the category: bug errors in the code or code behavior label Oct 8, 2024
@stephprince stephprince added the priority: high impacts proper operation or use of feature important to most users label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants