Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No module named 'typing_extensions' #522

Closed
3 tasks done
rly opened this issue Oct 2, 2024 · 2 comments · Fixed by #523
Closed
3 tasks done

[Bug]: No module named 'typing_extensions' #522

rly opened this issue Oct 2, 2024 · 2 comments · Fixed by #523
Labels
category: bug errors in the code or code behavior

Comments

@rly
Copy link
Contributor

rly commented Oct 2, 2024

What happened?

On a clean install of the main branch, running nwbinspector --config dandi path/to/file.nwb results in:

Traceback (most recent call last):
  File "/Users/rly/mambaforge/envs/test/bin/nwbinspector", line 5, in <module>
    from nwbinspector._nwbinspector_cli import _nwbinspector_cli
  File "/Users/rly/Documents/NWB/nwbinspector/src/nwbinspector/__init__.py", line 3, in <module>
    from ._registration import available_checks, register_check
  File "/Users/rly/Documents/NWB/nwbinspector/src/nwbinspector/_registration.py", line 11, in <module>
    from typing_extensions import Callable
ModuleNotFoundError: No module named 'typing_extensions'

This reference was just added in #520

I'm surprised the GitHub Actions tests passed. Perhaps typing_extensions is installed earlier in the GH Actions workflow. In this workflow, it looks like pip install ".[dandi]" is called. This installs typing_extensions, unlike pip install . I have not looked at all the workflows. If they all use pip install ".[dandi]", I think we should have some tests without the [dandi] flag too.

Operating System

Linux

Python Version

3.12

Were you streaming with ROS3?

None

Package Versions

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • Have you ensured this bug was not already reported?
  • To the best of your ability, have you ensured this is a bug within the code that checks the NWBFile, rather than a bug in the NWBFile reader (e.g., PyNWB or MatNWB)?
@rly rly added the category: bug errors in the code or code behavior label Oct 2, 2024
@stephprince
Copy link
Contributor

It looks like all the workflows use the pip install ".[dandi]" as you mentioned.

That makes sense to check that running without the dandi flag works as well. We could add a separate job or workflow file similar to testing.yml that runs without the dandi flag. I'm not sure if we need to do that across os and python versions since I think that would be running many of the unit tests twice, but maybe at least the latest python?

@rly
Copy link
Contributor Author

rly commented Oct 2, 2024

Fixed by #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants