Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add Check]: rate of TimeSeries is not zero #389

Closed
2 tasks done
CodyCBakerPhD opened this issue Jul 13, 2023 · 1 comment · Fixed by #404
Closed
2 tasks done

[Add Check]: rate of TimeSeries is not zero #389

CodyCBakerPhD opened this issue Jul 13, 2023 · 1 comment · Fixed by #404
Assignees
@alessandratrapani
Labels
category: new check a new best practices check to apply to all NWBFiles and their contents help wanted: good first issue request for community contributions that are good for new contributors

Comments

@CodyCBakerPhD
Copy link
Contributor

What would you like to see added to the NWBInspector?

Apparently it's possible for TimeSeries to have a rate set to 0.0, though that makes no sense when the series has more than one frame (technically there is an edge case for ImageSeries and its variants where it can be interpreted to mean a static ophys image)

Pseudocode or other logic of the check

No response

Do you have any interest in helping implement the check function?

Yes.

Code of Conduct
@CodyCBakerPhD CodyCBakerPhD added the category: new check a new best practices check to apply to all NWBFiles and their contents label Jul 13, 2023
@bendichter bendichter added the help wanted: good first issue request for community contributions that are good for new contributors label Jul 17, 2023
@bendichter
Copy link
Contributor

@alessandratrapani , could you take a look at this?

@alessandratrapani alessandratrapani mentioned this issue Sep 18, 2023
Merged
4 tasks
@CodyCBakerPhD CodyCBakerPhD linked a pull request Sep 18, 2023 that will close this issue
[New Check]: TimeSeries rate is zero #404
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessandratrapani alessandratrapani

Labels
category: new check a new best practices check to apply to all NWBFiles and their contents help wanted: good first issue request for community contributions that are good for new contributors
Projects
None yet
Milestone
No milestone
3 participants
@bendichter @CodyCBakerPhD @alessandratrapani