Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add Check]: entire col/row of table is not NaN, and entire axis of TimeSeries.data is not NaN #155

Open
2 tasks done
CodyCBakerPhD opened this issue Apr 7, 2022 · 0 comments · May be fixed by #229
Open
2 tasks done
Labels
category: new check a new best practices check to apply to all NWBFiles and their contents priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@CodyCBakerPhD
Copy link
Contributor

What would you like to see added to the NWBInspector?

We were in the process of making something like this inspired by the previous commented code, but was also discovered in a recent manual inspection.

Basically, an entire row or column of a DynamicTable, or an entire axis of a TimeSeries, should not all be NaN.

There are some exceptions that we have to observe such as x,y,z for ElectrodeTable. Basically any field that is required schematically but unknown in practice, we'd have to skip. But for axes optionally added or certainly custom fields, they should not be included if they are unknown.

Pseudocode or other logic of the check

all(np.isnan(getattr(obj, "data")))

Do you have any interest in helping implement the check function?

Yes.

Code of Conduct

@CodyCBakerPhD CodyCBakerPhD added the category: new check a new best practices check to apply to all NWBFiles and their contents label Apr 7, 2022
@CodyCBakerPhD CodyCBakerPhD self-assigned this Apr 11, 2022
@CodyCBakerPhD CodyCBakerPhD linked a pull request Nov 10, 2022 that will close this issue
@CodyCBakerPhD CodyCBakerPhD removed their assignment Sep 6, 2024
@stephprince stephprince added the priority: low alternative solution already working and/or relevant to only specific user(s) label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: new check a new best practices check to apply to all NWBFiles and their contents priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants