Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NIH Award Number Handling #814

Closed
garrettmflynn opened this issue May 29, 2024 · 1 comment · Fixed by #837
Closed

Improve NIH Award Number Handling #814

garrettmflynn opened this issue May 29, 2024 · 1 comment · Fixed by #837
Assignees

Comments

@garrettmflynn
Copy link
Member

Describe the issue

We discovered during the Developer Hackathon tests that an incorrect NIH Award Number will still allow you to submit, resulting in the registration of your Dandiset but a notice that the ID isn’t assigned to your account.

An additional issue was discovered that copying an Award Number straight off the NIH Reporter does not work because of improper spacing. The GUIDE should have a way to parse this directly.

Steps to Reproduce

  1. Complete a full conversion on a DANDI Upload workflow
  2. Click Create New Dandiset button
  3. Click that you would like to embargo your Dandiset
  4. Provide any arbitrary text in the NIH Award Number slot

Operating System

Mac M2

GUIDE Version

b60abb0

Code of Conduct

Yes

Did you confirm this issue was not already reported?

Yes

@garrettmflynn
Copy link
Member Author

An additional issue was discovered that copying an Award Number straight off the NIH Reporter does not work because of improper spacing. The GUIDE should have a way to parse this directly.

Skipping this since DANDI itself does not accept these directly.

@garrettmflynn garrettmflynn linked a pull request Jun 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants