Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Ensure Consistent Shortcut Behaviors (e.g. Return, Tab, etc.), ideally using Native Accessibility Interactions #806

Closed
garrettmflynn opened this issue May 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@garrettmflynn
Copy link
Member

What would you like to see added to the NWB GUIDE?

Using Return to advance through a form was previously implemented. However, this behavior notably diverges from the native Tab accessibility feature in several ways, including:

  1. Advancing past a select element
  2. Will not focus FilesystemSelector element
  3. Inconsistent behavior with a boolean selector (i.e. pressing Enter will select the currently focused button instead of advancing)
  4. Stuck on list inputs because Enter submits values to the list
  5. No ability to jump between accordions, even when open

Instead of maintaining an ad-hoc shortcut system on top of native accessibility features, it may be prudent to require users to leverage the native behaviors _except when adding instead of mirroring an interaction`.

For instance, the keywords input supports pressing Enter instead of the submit button to register a written keyword to the list. In the current implementation, this blocks the ad-hoc Enter advancement mechanism but is itself a useful behavior. This would be a good justification to keep this behavior while removing the mirrored Enter / Tab behavior.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

Yes

Did you confirm this feature was not already reported?

Yes

@garrettmflynn garrettmflynn added the enhancement New feature or request label May 29, 2024
@garrettmflynn garrettmflynn self-assigned this May 29, 2024
@garrettmflynn garrettmflynn changed the title [Feature]: Ensure Consistent Shortcut Behaviors (e.g. Return, Tab, etc.) following Native Accessibility Interactions [Feature]: Ensure Consistent Shortcut Behaviors (e.g. Return, Tab, etc.), ideally using Native Accessibility Interactions May 29, 2024
@garrettmflynn
Copy link
Member Author

Not sure where it comes from, but there's also a weird issue where you can tab backwards, but not forwards, through editable list items like the keywords list.

@CodyCBakerPhD
Copy link
Collaborator

Summarized and moved to #846

Re-open again whenever this starts active development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants