Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undoing Add Row to HandsOnTable has odd behavior #592

Closed
rly opened this issue Feb 6, 2024 · 3 comments
Closed

Undoing Add Row to HandsOnTable has odd behavior #592

rly opened this issue Feb 6, 2024 · 3 comments
Labels
enhancement New feature or request priority: low

Comments

@rly
Copy link
Collaborator

rly commented Feb 6, 2024

A user pressed Cmd-Z repeatedly to try to undo adding a new subject to the subjects table. That moved the selector through the columns until it got to the first one and then the row was deleted. Can we change the behavior of Cmd-Z immediately after adding a row to remove the whole row?

Version: Main branch on Mac M1, 0.0.13 on Mac

@rly rly added enhancement New feature or request priority: low labels Feb 6, 2024
@CodyCBakerPhD
Copy link
Collaborator

Depends on how easy it is to make ctrl-z undo row addition as an action; if tricky, the actual problem is countered by the instructions below every table to double-click to add/remove rows - that text simply needs to be larger and less gray

@garrettmflynn
Copy link
Member

Ah. This is because I'm forcing the validation of each cell when the row initializes, which behaves as if the user has input all that text (including if empty) themselves. This means that it registers as an undoable action.

I'll see what I can do to get around this naive way of triggering the validation behavior.

@CodyCBakerPhD
Copy link
Collaborator

Summarized and moved to #846

Re-open again whenever this starts active development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: low
Projects
None yet
Development

No branches or pull requests

3 participants