Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage sessions through the Source Data instance manager rather than the Subjects table #224

Closed
garrettmflynn opened this issue Jun 13, 2023 · 4 comments
Assignees

Comments

@garrettmflynn
Copy link
Member

To allow the Subjects page to focus on subject data, we will move this capability to the Source Data instance manager.

While doing this, we should make sure that there is the ability to add and remove sessions from each subject.

@garrettmflynn garrettmflynn self-assigned this Jun 13, 2023
@garrettmflynn
Copy link
Member Author

@CodyCBakerPhD This is inconsistent with #482. Assuming we aren't pursuing this direction anymore?

@CodyCBakerPhD
Copy link
Collaborator

I think they're kind of compatible - the main idea was still to have the session management separated from the subject table

Whether or not that is a table on the same page or a button in the manager form on the next page is the main difference; the table seems simpler

@garrettmflynn
Copy link
Member Author

garrettmflynn commented Nov 6, 2023

Yeah I agree. Even if we moved the table to a separate page, the general idea of isolating Session specification from other metadata specification is a smart move for one-directional data flow.

This Issue just seems overly attached to one method rather than that rationale, unlike #482

@CodyCBakerPhD
Copy link
Collaborator

replaced by #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants