diff --git a/.codespellrc b/.codespellrc new file mode 100644 index 000000000..6b0aa92f0 --- /dev/null +++ b/.codespellrc @@ -0,0 +1,3 @@ +[codespell] +ignore-words-list= afterall +skip = .git,*.svg,package-lock.json,node_modules,*lotties*,nwb-guide.spec,prepare_pyinstaller_spec.py diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml index 0ddc084e4..09b74deac 100644 --- a/.github/workflows/chromatic.yml +++ b/.github/workflows/chromatic.yml @@ -2,8 +2,8 @@ name: Chromatic on: workflow_dispatch: - #pull_request_review: - # types: [submitted] + pull_request_review: + types: [submitted] jobs: test: diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml new file mode 100644 index 000000000..243ba8ce5 --- /dev/null +++ b/.github/workflows/codespell.yml @@ -0,0 +1,19 @@ +--- +name: Codespell + +on: + push: + branches: [main] + pull_request: + branches: [main] + +jobs: + codespell: + name: Check for spelling errors + runs-on: ubuntu-latest + + steps: + - name: Checkout + uses: actions/checkout@v3 + - name: Codespell + uses: codespell-project/actions-codespell@v1 diff --git a/prepare_pyinstaller_spec.py b/prepare_pyinstaller_spec.py index 497ae93f4..5c0a36849 100644 --- a/prepare_pyinstaller_spec.py +++ b/prepare_pyinstaller_spec.py @@ -40,4 +40,4 @@ with open(file=Path(__file__).parent / "nwb-guide.spec", mode="w") as io: io.writelines(lines) -print("Sucessfully injected recursion depth extension and json paths!") +print("Successfully injected recursion depth extension and json paths!") diff --git a/src/renderer/assets/css/global.css b/src/renderer/assets/css/global.css index 912b35d5d..cd77a8707 100755 --- a/src/renderer/assets/css/global.css +++ b/src/renderer/assets/css/global.css @@ -12,7 +12,7 @@ margin-top: 0px !important; } -/* Notfy */ +/* Notyf */ .notyf__toast { max-width: 40vw !important; } diff --git a/src/renderer/assets/css/guided.css b/src/renderer/assets/css/guided.css index 0f909475c..518c1c883 100644 --- a/src/renderer/assets/css/guided.css +++ b/src/renderer/assets/css/guided.css @@ -1,6 +1,6 @@ @import url("https://fonts.googleapis.com/css?family=Poppins:400,500,600,700"); -/* change the font to siblints of guided--body to Poppins except i elemenets */ +/* change the font to siblints of guided--body to Poppins except i elements */ /*.guided--body *:not(i) { font-family: "Poppins", sans-serif; diff --git a/src/renderer/src/stories/JSONSchemaInput.js b/src/renderer/src/stories/JSONSchemaInput.js index 7baeff74c..2ba7acea7 100644 --- a/src/renderer/src/stories/JSONSchemaInput.js +++ b/src/renderer/src/stories/JSONSchemaInput.js @@ -1090,7 +1090,7 @@ export class JSONSchemaInput extends LitElement { if (schema.transform) newValue = schema.transform(newValue, this.value, schema); - // // Do not check patter if value is empty + // // Do not check pattern if value is empty // if (schema.pattern && !isBlank) { // const regex = new RegExp(schema.pattern) // if (!regex.test(isNaN(newValue) ? value : newValue)) newValue = this.value // revert to last value diff --git a/src/renderer/src/stories/pages/guided-mode/data/GuidedMetadata.js b/src/renderer/src/stories/pages/guided-mode/data/GuidedMetadata.js index 9355df593..636b4faa9 100644 --- a/src/renderer/src/stories/pages/guided-mode/data/GuidedMetadata.js +++ b/src/renderer/src/stories/pages/guided-mode/data/GuidedMetadata.js @@ -228,7 +228,7 @@ export class GuidedMetadataPage extends ManagedPage { ignore: propsToIgnore, onOverride: (name) => { - this.notify(`${header(name)} has been overriden with a global value.`, "warning", 3000); + this.notify(`${header(name)} has been overridden with a global value.`, "warning", 3000); }, transformErrors: (error) => { diff --git a/src/renderer/src/stories/pages/guided-mode/data/GuidedSourceData.js b/src/renderer/src/stories/pages/guided-mode/data/GuidedSourceData.js index 335d25ddc..93fb40053 100644 --- a/src/renderer/src/stories/pages/guided-mode/data/GuidedSourceData.js +++ b/src/renderer/src/stories/pages/guided-mode/data/GuidedSourceData.js @@ -164,7 +164,7 @@ export class GuidedSourceDataPage extends ManagedPage { ignore: propsToIgnore, globals: this.info.globalState.project.SourceData, onOverride: (name) => { - this.notify(`${header(name)} has been overriden with a global value.`, "warning", 3000); + this.notify(`${header(name)} has been overridden with a global value.`, "warning", 3000); }, // onlyRequired: true, onUpdate: () => (this.unsavedUpdates = "conversions"), diff --git a/src/renderer/src/stories/pages/guided-mode/data/GuidedStructure.js b/src/renderer/src/stories/pages/guided-mode/data/GuidedStructure.js index 1f56acf85..0d8a72694 100644 --- a/src/renderer/src/stories/pages/guided-mode/data/GuidedStructure.js +++ b/src/renderer/src/stories/pages/guided-mode/data/GuidedStructure.js @@ -95,7 +95,7 @@ export class GuidedStructurePage extends Page { }); } - await this.save(undefined, false); // Interrim save, in case the schema request fails + await this.save(undefined, false); // Interim save, in case the schema request fails await this.getSchema(); }; diff --git a/src/renderer/src/stories/pages/guided-mode/options/GuidedUpload.js b/src/renderer/src/stories/pages/guided-mode/options/GuidedUpload.js index d9f100a26..80d0cf784 100644 --- a/src/renderer/src/stories/pages/guided-mode/options/GuidedUpload.js +++ b/src/renderer/src/stories/pages/guided-mode/options/GuidedUpload.js @@ -105,7 +105,7 @@ export class GuidedUploadPage extends Page { if ("results" in globalUploadInfo) { const result = await Swal.fire({ title: "This pipeline has already uploaded to DANDI", - html: "Would you like to reupload the lastest files?", + html: "Would you like to reupload the latest files?", icon: "warning", showCancelButton: true, confirmButtonColor: "#3085d6", diff --git a/src/renderer/src/stories/pages/guided-mode/setup/GuidedNewDatasetInfo.js b/src/renderer/src/stories/pages/guided-mode/setup/GuidedNewDatasetInfo.js index ab284465e..86e8893d0 100644 --- a/src/renderer/src/stories/pages/guided-mode/setup/GuidedNewDatasetInfo.js +++ b/src/renderer/src/stories/pages/guided-mode/setup/GuidedNewDatasetInfo.js @@ -91,7 +91,7 @@ export class GuidedNewDatasetPage extends Page { properties: ["createDirectory"], }, onOverride: (name) => { - this.notify(`${header(name)} has been overriden with a global value.`, "warning", 3000); + this.notify(`${header(name)} has been overridden with a global value.`, "warning", 3000); }, validateOnChange, onUpdate: () => (this.unsavedUpdates = true), diff --git a/src/renderer/src/stories/pages/guided-mode/setup/GuidedSubjects.js b/src/renderer/src/stories/pages/guided-mode/setup/GuidedSubjects.js index a110d9398..82e4f8c7b 100644 --- a/src/renderer/src/stories/pages/guided-mode/setup/GuidedSubjects.js +++ b/src/renderer/src/stories/pages/guided-mode/setup/GuidedSubjects.js @@ -131,7 +131,7 @@ export class GuidedSubjectsPage extends Page { }, onThrow: (message, type) => this.notify(message, type), onOverride: (name) => { - this.notify(`${header(name)} has been overriden with a global value.`, "warning", 3000); + this.notify(`${header(name)} has been overridden with a global value.`, "warning", 3000); }, onUpdate: () => { console.log("UPDATED!"); diff --git a/src/renderer/src/stories/preview/inspector/InspectorList.js b/src/renderer/src/stories/preview/inspector/InspectorList.js index 7761b67e5..5b52676f0 100644 --- a/src/renderer/src/stories/preview/inspector/InspectorList.js +++ b/src/renderer/src/stories/preview/inspector/InspectorList.js @@ -14,10 +14,10 @@ const sortList = (items) => { else return 1; }) .sort((a, b) => { - const aLow = a.severity == "LOW"; - const bLow = b.severity === "LOW"; - if (aLow && bLow) return 0; - else if (aLow) return 1; + const lowA = a.severity == "LOW"; + const lowB = b.severity === "LOW"; + if (lowA && lowB) return 0; + else if (lowA) return 1; else return -1; }); }; diff --git a/tests/e2e.test.ts b/tests/e2e.test.ts index efa61cf4c..336b972ee 100644 --- a/tests/e2e.test.ts +++ b/tests/e2e.test.ts @@ -130,7 +130,7 @@ describe('E2E Test', () => { const dashboard = document.querySelector('nwb-dashboard') dashboard.sidebar.select('settings') - // Genereate test data + // Generate test data const page = dashboard.page page.deleteTestData() return await page.generateTestData() @@ -319,7 +319,7 @@ describe('E2E Test', () => { await toNextPage('sourcedata') - }) + }, 10 * 1000) test('Review source data information', async () => { @@ -342,7 +342,7 @@ describe('E2E Test', () => { await toNextPage('inspect') - }, 20 * 1000) // Wait for conversion to complete + }, 30 * 1000) // Wait for conversion to complete test('Review NWB Inspector output', async () => {