diff --git a/src/io/ReadIO.hpp b/src/io/ReadIO.hpp index 06562c1..83c8d51 100644 --- a/src/io/ReadIO.hpp +++ b/src/io/ReadIO.hpp @@ -170,23 +170,21 @@ class DataBlock /// Helper struct to check if a StorageObjectType is allowed. Used in static /// assert. template -struct is_allowed_storage_object_type : std::false_type +struct isAllowedStorageObjectType : std::false_type { }; /// Helper struct to check if a StorageObjectType is allowed. Used in static /// assert. template<> -struct is_allowed_storage_object_type - : std::true_type +struct isAllowedStorageObjectType : std::true_type { }; /// Helper struct to check if a StorageObjectType is allowed. Used in static /// assert. template<> -struct is_allowed_storage_object_type - : std::true_type +struct isAllowedStorageObjectType : std::true_type { }; @@ -213,7 +211,7 @@ class ReadDataWrapper * slicing. */ template - struct is_dataset + struct isDataset : std::integral_constant { }; @@ -224,7 +222,7 @@ class ReadDataWrapper * StorageObjectType::Attribute but not for other types, e.g., Group or * Undefined. */ - static_assert(is_allowed_storage_object_type::value, + static_assert(isAllowedStorageObjectType::value, "StorageObjectType not allowed for ReadDataWrapper"); // Actual definition of the class @@ -340,7 +338,7 @@ class ReadDataWrapper * @return An DataBlockGeneric structure containing the data and shape. */ template::value, int>::type = 0> + typename std::enable_if::value, int>::type = 0> inline DataBlockGeneric valuesGeneric( const std::vector& start, const std::vector& count = {}, @@ -397,7 +395,7 @@ class ReadDataWrapper */ template::value, int>::type = 0> + typename std::enable_if::value, int>::type = 0> inline DataBlock values(const std::vector& start, const std::vector& count = {}, const std::vector& stride = {}, diff --git a/src/io/hdf5/HDF5IO.hpp b/src/io/hdf5/HDF5IO.hpp index 260080f..017926d 100644 --- a/src/io/hdf5/HDF5IO.hpp +++ b/src/io/hdf5/HDF5IO.hpp @@ -339,7 +339,6 @@ class HDF5IO : public BaseIO private: /** -<<<<<<< HEAD:src/io/hdf5/HDF5IO.hpp * @brief Reads data from an HDF5 dataset or attribute into a vector of the * appropriate type. * diff --git a/src/nwb/NWBFile.cpp b/src/nwb/NWBFile.cpp index d688bf1..f34d2a4 100644 --- a/src/nwb/NWBFile.cpp +++ b/src/nwb/NWBFile.cpp @@ -147,16 +147,7 @@ Status NWBFile::createElectricalSeries( AQNWB::mergePaths(acquisitionPath, recordingName); // Check if device exists for groupName, create device and electrode group - // if not - if (!m_io->objectExists(devicePath)) { - Device device = Device(devicePath, m_io); - device.initialize("description", "unknown"); - - ElectrodeGroup elecGroup = ElectrodeGroup(electrodePath, m_io); - elecGroup.initialize("description", "unknown", device); - } - - // Setup electrical series datasets + // if it does not if (!m_io->objectExists(devicePath)) { Device device = Device(devicePath, m_io); device.initialize("description", "unknown"); diff --git a/src/nwb/ecephys/ElectricalSeries.cpp b/src/nwb/ecephys/ElectricalSeries.cpp index b6cfdcb..86210ab 100644 --- a/src/nwb/ecephys/ElectricalSeries.cpp +++ b/src/nwb/ecephys/ElectricalSeries.cpp @@ -65,6 +65,7 @@ void ElectricalSeries::initialize(const IO::BaseDataType& dataType, m_io->createAttribute(IO::BaseDataType::I32, &axis_value, AQNWB::mergePaths(getPath(), "channel_conversion"), + this->getPath() + "/channel_conversion", "axis", 1); diff --git a/src/nwb/hdmf/base/Data.hpp b/src/nwb/hdmf/base/Data.hpp index 26c93b1..3e2e17d 100644 --- a/src/nwb/hdmf/base/Data.hpp +++ b/src/nwb/hdmf/base/Data.hpp @@ -47,7 +47,6 @@ class Data : public RegisteredType */ inline bool isInitialized() { return m_dataset != nullptr; } - std::unique_ptr - m_dataset; // TODO We may not want this here if we need Data for read + std::unique_ptr m_dataset; }; } // namespace AQNWB::NWB