Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to using C++17 #766

Closed
MatthewDaggitt opened this issue Feb 21, 2024 · 2 comments · Fixed by #770
Closed

Upgrade to using C++17 #766

MatthewDaggitt opened this issue Feb 21, 2024 · 2 comments · Fixed by #770
Labels
project

Comments

@MatthewDaggitt
Copy link
Collaborator

In order to support Pytorch (see #754), we need to upgrade from C++11 to C++17. This issue is to discuss.
@MatthewDaggitt
Copy link
Collaborator Author

MatthewDaggitt commented Feb 21, 2024 •
edited
Loading

Heads up that the version seems to be hard-coded in:

  • download_boost.sh
  • our version of pybind

@wu-haoze
Copy link
Collaborator

Turns out the 11 in pybind11 is the lower limit. pybind11 works with versions after C11.

For boost, a flag needs to be set to not use deprecated operations.

@wu-haoze wu-haoze linked a pull request Feb 27, 2024 that will close this issue
C++11 -> C++17 #770
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

C++11 -> C++17 wu-haoze/Marabou
2 participants
@MatthewDaggitt @wu-haoze