Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM exposed query() function uses golang doh-client which hardcodes defacto default DOH path component #59

Closed
adam-burns opened this issue Aug 12, 2024 · 2 comments

Comments

@adam-burns
Copy link
Collaborator

adam-burns commented Aug 12, 2024

Referring to query() in wrapper_js.go:

dohurl also supports receiving a full url but actually only takes the host from that. we would need to patch github.com/shynome/doh-client for it to construct it's url differently here https://github.com/shynome/doh-client/blob/3b78e35dadc53df5cf253bde3692e59507584a92/conn.go#L30

Originally posted by @cryptix in #58 (comment)

@adam-burns
Copy link
Collaborator Author

It's good that dohurl supports the full URL, as the JS function findDOHEndpoint() in pure.js in its current form picks up the dohUrl as a single URL string, not as components. Javascipt should only query our SVCB RR entries for each enabled zone which will work as long as the defacto example path in RFC8484 is used, which is also used as the default path in BIND9 and its DOH configuration.

Issue raised in doh-client project shynome/doh-client#1.

@adam-burns
Copy link
Collaborator Author

Issue in doh-client fixed in shynome/doh-client@5d1eb76 by allowing server variable to be a URL, and if so, ingests the whole endpoint, including the path component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant