Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging out discards the current project #1521

Open
dragazo opened this issue Mar 7, 2024 · 4 comments
Open

Logging out discards the current project #1521

dragazo opened this issue Mar 7, 2024 · 4 comments

Comments

@dragazo
Copy link

dragazo commented Mar 7, 2024

It looks like logging out of your account also closes the current project without prompting and without saving.

@gsteinLTU
Copy link
Member

IDE_Morph.prototype.logout = async function () {
could probably have a this.prompt in it if you currently have a project open.

@dragazo
Copy link
Author

dragazo commented Mar 21, 2024

That would help, but it seems like we should be able to just log out without discarding the session. Like that call to newProject() at the end probably isn't necessary. If no one knows of any invisible consequences, I'll just make a PR to remove that.

@gsteinLTU
Copy link
Member

Good idea, hopefully it's that simple, although do we need to decide on things like what should happen if you're collaborating?

@gsteinLTU
Copy link
Member

I did a quick test of removing that line and it almost works. If you make a project and log out, it will keep it open, but trying to do anything will have it ask if you want to request to collaborate. Sometimes clicking yes will result in a popup asking if you (who is logged out) would like to make "null" a collaborator. Clicking yes will tell you "Login required."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants