New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match browser regex for valid names to cloud regex #1464

Open

gsteinLTU opened this issue Nov 14, 2023 · 0 comments

Member

gsteinLTU commented Nov 14, 2023

Browser and cloud seem to have different ideas of what names for rooms/roles are valid:

Snap--Build-Your-Own-Blocks/src/room.js

Line 21 in e41e05b

return !/[@\.]+/.test(name);

https://github.com/NetsBlox/cloud/blob/81113bfbd79420c4ab60f0699f610b4a1426b936/crates/cloud/src/utils.rs#L99

For example, cloud has a test for "untitled v1.2" being valid, but browser rejects it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment