Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assembler can't handle %{ %} casm blocks #190

Open
quasilyte opened this issue Jan 24, 2024 · 0 comments
Open

assembler can't handle %{ %} casm blocks #190

quasilyte opened this issue Jan 24, 2024 · 0 comments
Labels
needs discussion Discuss solution before start implementing it

Comments

@quasilyte
Copy link
Contributor

We may want to treat them as comments for now.
Cairo1 compiler still produces inline-hints in some modes.
Treating them as comments looks better than a parse failure.

Here is an example of a casm file that contains {%%} blocks:
https://github.com/starkware-libs/cairo/blob/405b84767f01d6c98a0db3351e89c51b921f3389/tests/test_data/match_or.casm#L92

I'm not sure we're interested in extracting the pythonic hints from this source, but it's also doable.
This issue is just about the inability to use any casm files that contain inline cairo0-style hints inside them in our test suits.

@quasilyte quasilyte self-assigned this Jan 29, 2024
@quasilyte quasilyte changed the title assembler can't handle {%%} casm blocks assembler can't handle %{ %} casm blocks Feb 9, 2024
@rodrigo-pino rodrigo-pino added the needs discussion Discuss solution before start implementing it label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Discuss solution before start implementing it
Projects
None yet
Development

No branches or pull requests

2 participants